You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/04/20 23:07:30 UTC
Review Request 33373: Fix broken unit tests on builds.apache.org in
TestActionScheduler and AmbariManagementControllerImplTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33373/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle.
Bugs: AMBARI-10612
https://issues.apache.org/jira/browse/AMBARI-10612
Repository: ambari
Description
-------
Several unit tests are broken,
https://builds.apache.org/job/Ambari-trunk-Commit/2362/ started failing in
```
Tests in error:
testActionTimeout(org.apache.ambari.server.actionmanager.TestActionScheduler)
testCancelRequests(org.apache.ambari.server.actionmanager.TestActionScheduler)
testInvalidAlertDefinition(org.apache.ambari.server.state.alerts.AlertReceivedListenerTest): Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException(..)
```
Last build, https://builds.apache.org/job/Ambari-trunk-Commit/2375/consoleFull
has been failing with,
```
testActionTimeout(org.apache.ambari.server.actionmanager.TestActionScheduler)
testCancelRequests(org.apache.ambari.server.actionmanager.TestActionScheduler)
testCreateDefaultHostParams(org.apache.ambari.server.controller.AmbariManagementControllerImplTest)
```
mvn clean test
AmbariManagementControllerImplTest (fails locally and on BAO)
RootServiceResponseFactoryTest (failed locally only, but not via IDE)
TestActionScheduler (fails only on BAO)
Diffs
-----
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java e565922
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 5778434
Diff: https://reviews.apache.org/r/33373/diff/
Testing
-------
mvn clean test
All unit tests passed locally, and the individual tests that were failing passed when ran as a singleton.
Thanks,
Alejandro Fernandez
Re: Review Request 33373: Fix broken unit tests on builds.apache.org
in TestActionScheduler and AmbariManagementControllerImplTest
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33373/#review80831
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 20, 2015, 5:17 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33373/
> -----------------------------------------------------------
>
> (Updated April 20, 2015, 5:17 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle.
>
>
> Bugs: AMBARI-10612
> https://issues.apache.org/jira/browse/AMBARI-10612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Several unit tests are broken,
>
> https://builds.apache.org/job/Ambari-trunk-Commit/2362/ started failing in
> ```
> Tests in error:
> testActionTimeout(org.apache.ambari.server.actionmanager.TestActionScheduler)
> testCancelRequests(org.apache.ambari.server.actionmanager.TestActionScheduler)
> testInvalidAlertDefinition(org.apache.ambari.server.state.alerts.AlertReceivedListenerTest): Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException(..)
> ```
>
> Last build, https://builds.apache.org/job/Ambari-trunk-Commit/2375/consoleFull
> has been failing with,
> ```
> testActionTimeout(org.apache.ambari.server.actionmanager.TestActionScheduler)
> testCancelRequests(org.apache.ambari.server.actionmanager.TestActionScheduler)
> testCreateDefaultHostParams(org.apache.ambari.server.controller.AmbariManagementControllerImplTest)
> ```
>
> mvn clean test
> AmbariManagementControllerImplTest (fails locally and on BAO)
> RootServiceResponseFactoryTest (failed locally only, but not via IDE)
> TestActionScheduler (fails only on BAO)
>
>
> Diffs
> -----
>
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java e565922
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 5778434
>
> Diff: https://reviews.apache.org/r/33373/diff/
>
>
> Testing
> -------
>
> mvn clean test
> All unit tests passed locally, and the individual tests that were failing passed when ran as a singleton.
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 33373: Fix broken unit tests on builds.apache.org
in TestActionScheduler and AmbariManagementControllerImplTest
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33373/
-----------------------------------------------------------
(Updated April 20, 2015, 9:17 p.m.)
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Sid Wagle.
Bugs: AMBARI-10612
https://issues.apache.org/jira/browse/AMBARI-10612
Repository: ambari
Description
-------
Several unit tests are broken,
https://builds.apache.org/job/Ambari-trunk-Commit/2362/ started failing in
```
Tests in error:
testActionTimeout(org.apache.ambari.server.actionmanager.TestActionScheduler)
testCancelRequests(org.apache.ambari.server.actionmanager.TestActionScheduler)
testInvalidAlertDefinition(org.apache.ambari.server.state.alerts.AlertReceivedListenerTest): Exception [EclipseLink-4002] (Eclipse Persistence Services - 2.5.2.v20140319-9ad6abd): org.eclipse.persistence.exceptions.DatabaseException(..)
```
Last build, https://builds.apache.org/job/Ambari-trunk-Commit/2375/consoleFull
has been failing with,
```
testActionTimeout(org.apache.ambari.server.actionmanager.TestActionScheduler)
testCancelRequests(org.apache.ambari.server.actionmanager.TestActionScheduler)
testCreateDefaultHostParams(org.apache.ambari.server.controller.AmbariManagementControllerImplTest)
```
mvn clean test
AmbariManagementControllerImplTest (fails locally and on BAO)
RootServiceResponseFactoryTest (failed locally only, but not via IDE)
TestActionScheduler (fails only on BAO)
Diffs (updated)
-----
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java e565922
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 5778434
Diff: https://reviews.apache.org/r/33373/diff/
Testing
-------
mvn clean test
All unit tests passed locally, and the individual tests that were failing passed when ran as a singleton.
Thanks,
Alejandro Fernandez