You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aihua Xu <ax...@cloudera.com> on 2015/06/08 20:33:15 UTC
Review Request 35218: HIVE-10963 Hive throws NPE rather than
meaningful error message when window is missing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35218/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-10963 Hive throws NPE rather than meaningful error message when window is missing
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 953f3ae8ab583e2a7be28a0f1a05871f38c09d58
ql/src/test/queries/clientnegative/ptf_negative_NoWindowDefn.q PRE-CREATION
ql/src/test/results/clientnegative/ptf_negative_NoWindowDefn.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/35218/diff/
Testing
-------
Thanks,
Aihua Xu
Re: Review Request 35218: HIVE-10963 Hive throws NPE rather than
meaningful error message when window is missing
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35218/#review87097
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java
<https://reviews.apache.org/r/35218/#comment139388>
Nit : Can you do these initializations in default constructor? That way these objects are created only when class is instantiated as oppose as soon as it is loaded by class loader.
ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java
<https://reviews.apache.org/r/35218/#comment139389>
It will be good to add PartitionSpec as well as WindowFrameSpec in toString() (with null checks)
- Ashutosh Chauhan
On June 8, 2015, 6:33 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35218/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 6:33 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-10963 Hive throws NPE rather than meaningful error message when window is missing
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 953f3ae8ab583e2a7be28a0f1a05871f38c09d58
> ql/src/test/queries/clientnegative/ptf_negative_NoWindowDefn.q PRE-CREATION
> ql/src/test/results/clientnegative/ptf_negative_NoWindowDefn.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 35218: HIVE-10963 Hive throws NPE rather than
meaningful error message when window is missing
Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35218/
-----------------------------------------------------------
(Updated June 9, 2015, 2:40 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-10963 Hive throws NPE rather than meaningful error message when window is missing
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 48e3cc7
ql/src/java/org/apache/hadoop/hive/ql/parse/PTFInvocationSpec.java 06d3f4b
ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 953f3ae
ql/src/test/queries/clientnegative/ptf_negative_NoWindowDefn.q PRE-CREATION
ql/src/test/results/clientnegative/ptf_negative_NoWindowDefn.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/35218/diff/
Testing
-------
Thanks,
Aihua Xu