[GitHub] [hive] risdenk commented on a change in pull request #1594: HIVE-24292: hive webUI should support keystoretype by config

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #1594:
URL: https://github.com/apache/hive/pull/1594#discussion_r509800907



##########
File path: service/src/test/org/apache/hive/service/server/TestHS2HttpServerPamConfiguration.java
##########
@@ -48,6 +48,7 @@
   private static HiveConf hiveConf = null;
   private static String keyStorePassword = "123456";
   private static String keyFileName = "myKeyStore";
+  private static String keyStoreType = "jks";

Review comment:
       You might want this to be `KeyStore. getDefaultType()` depending on the JDK being used? I think in most cases this should be ok though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org