Re: [PR] [cleanup][metadatastore] cleanup deprecated method of metadata store etcd [pulsar]

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower commented on code in PR #21253:
URL: https://github.com/apache/pulsar/pull/21253#discussion_r1349891541


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java:
##########
@@ -109,9 +109,9 @@ public EtcdMetadataStore(String metadataURL, MetadataStoreConfig conf, boolean e
         try {
             this.client = newEtcdClient(metadataURL, conf);
             this.kv = client.getKVClient();
-            this.client.getWatchClient().watch(ByteSequence.from("\0", StandardCharsets.UTF_8),
+            this.client.getWatchClient().watch(ByteSequence.from("/", StandardCharsets.UTF_8),

Review Comment:
   This modification is beyond the scope of the PR description. You need to add a test to protect this change.



##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java:
##########
@@ -285,7 +285,7 @@ protected void batchOperation(List<MetadataOp> ops) {
                                 .withKeysOnly(true)
                                 .withSortField(GetOption.SortTarget.KEY)
                                 .withSortOrder(GetOption.SortOrder.ASCEND)
-                                .withPrefix(prefix)
+                                        .isPrefix(true)

Review Comment:
   Please don't change the indent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org