[jira] [Commented] (MAPREDUCE-6096) SummarizedJob class should be Improvment

["zhangyubiao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143166#comment-14143166 ] 

zhangyubiao commented on MAPREDUCE-6096:
----------------------------------------

MAPREDUCE-6096.patch for review

> SummarizedJob class should be Improvment 
> -----------------------------------------
>
>                 Key: MAPREDUCE-6096
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6096
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobhistoryserver
>    Affects Versions: trunk
>            Reporter: zhangyubiao
>            Assignee: zhangyubiao
>              Labels: easyfix, patch
>             Fix For: trunk
>
>         Attachments: MAPREDUCE-6096.patch
>
>
> When I Parse  the JobHistory in the HistoryFile,I use the Hadoop System's  map-reduce-client-core project org.apache.hadoop.mapreduce.jobhistory.JobHistoryParser  class and HistoryViewer$SummarizedJob to Parse the JobHistoryFile(Just Like job_1408862281971_489761-1410883171851_XXX.jhist)  
> and it throw an Exception Just Like 
> Exception in thread "pool-1-thread-1" java.lang.NullPointerException
> 	at org.apache.hadoop.mapreduce.jobhistory.HistoryViewer$SummarizedJob.<init>(HistoryViewer.java:626)
> 	at com.jd.hadoop.log.parse.ParseLogService.getJobDetail(ParseLogService.java:70)
> After I'm see the SummarizedJob class I  find that attempt.getTaskStatus() is NULL ， So I change the order of 
> attempt.getTaskStatus().equals (TaskStatus.State.FAILED.toString())  to 
> TaskStatus.State.FAILED.toString().equals(attempt.getTaskStatus()) 
> and it works well .
> So I wonder If we can change all  attempt.getTaskStatus()  after TaskStatus.State.XXX.toString() ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)