[jira] [Commented] (YARN-9375) Use Configured in GpuDiscoverer and FpgaDiscoverer

["Szilard Nemeth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789325#comment-16789325 ] 

Szilard Nemeth commented on YARN-9375:
--------------------------------------

This is a good idea. I had a similar idea before but wasn't aware that we already have a class for this (Configured).

> Use Configured in GpuDiscoverer and FpgaDiscoverer
> --------------------------------------------------
>
>                 Key: YARN-9375
>                 URL: https://issues.apache.org/jira/browse/YARN-9375
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager, yarn
>    Affects Versions: 3.2.0
>            Reporter: Adam Antal
>            Assignee: Adam Antal
>            Priority: Major
>
> Both GpuDiscoverer and FpgaDiscoverer has Configuration object passing around. Both class can extend the Configured class which is dedicated to handle this. This refactor would make the class cleaner and would separate the responsibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org