You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/14 05:45:31 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6064: sched/environ: Ensure tg_envp terminated by double '\0'

xiaoxiang781216 commented on PR #6064:
URL: https://github.com/apache/incubator-nuttx/pull/6064#issuecomment-1098731988

   > LGTM, just need to remember when copying envp must always memcpy(..., tg_envlen + 1);
   > 
   > If you merge this patch I can clean #6010 up and calculate envp size by traversing the strings.
   
   @pussuw after more thought, it's more better to change the environment layout to the array of string, since we can support execle, execvpe natively:
   https://man7.org/linux/man-pages/man3/exec.3.html
   Could you wait one or two days? So I can finish the modification of environ layout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org