You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/06/06 12:28:30 UTC
[GitHub] [arrow] thisisnic opened a new issue, #35936: [R] CRAN packaging checklist for version 12.0.1
thisisnic opened a new issue, #35936:
URL: https://github.com/apache/arrow/issues/35936
- [ ] [Create a GitHub issue](https://github.com/apache/arrow/issues/new/)
entitled `[R] CRAN packaging checklist for version X.X.X`
and copy this checklist to the issue.
- [ ] Evaluate the status of any failing
[nightly tests and nightly packaging builds](http://crossbow.voltrondata.com). These checks
replicate most of the checks that CRAN runs, so we need them all to be passing
or to understand that the failures may (though won't necessarily) result in a rejection from CRAN.
- [ ] Check [current CRAN check results](https://cran.rstudio.org/web/checks/check_results_arrow.html)
- [ ] Ensure the contents of the README are accurate and up to date
- [ ] Run `urlchecker::url_check()` on the R directory at the release candidate
commit. Ignore any errors with badges as they will be removed in the CRAN release branch.
- [ ] [Polish NEWS](https://style.tidyverse.org/news.html#news-release) but do **not** update version numbers (this is done automatically later).
- [ ] For major releases, prepare tweet thread highlighting new features
Wait for the release candidate to be cut:
- [ ] Release candidate!
- [ ] Create a CRAN-release branch from the release candidate commit
Make pull requests into the [autobrew](https://github.com/autobrew) and
[rtools-packages](https://github.com/r-windows/rtools-packages) repositories
used by the configure script on MacOS and Windows. These pull requests will
use the release candidate as the source.
- [ ] Pull request to modify
[the apache-arrow autobrew formula]( https://github.com/autobrew/homebrew-core/blob/high-sierra/Formula/apache-arrow.rb)
to update the release version, SHA256 checksum of the release source file (which can be found in the same directory as the release source file), and any changes to dependencies and build steps that have changed in the
[copy of the formula we have of that formula in the Arrow repo](https://github.com/apache/arrow/blob/main/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb)
- [ ] Pull request to modify
[the apache-arrow-static autobrew formula](https://github.com/autobrew/homebrew-cran/blob/master/Formula/apache-arrow-static.rb)
to update the version, SHA, and any changes to dependencies and build steps that have changed in the
[copy of the formula we have of that formula in the Arrow repo](https://github.com/apache/arrow/blob/main/dev/tasks/homebrew-formulae/autobrew/apache-arrow-static.rb)
- [ ] Pull request to modify the
[autobrew script](https://github.com/autobrew/scripts/blob/master/apache-arrow)
to include any additions made to
[r/tools/autobrew](https://github.com/apache/arrow/blob/main/r/tools/autobrew).
- [ ] Pull request to modify the
[RTools PKGBUILD script](https://github.com/r-windows/rtools-packages/blob/master/mingw-w64-arrow/PKGBUILD)
to reflect changes in
[ci/PKGBUILD](https://github.com/apache/arrow/blob/main/ci/scripts/PKGBUILD),
uncommenting the line that says "uncomment to test the rc".
Prepare and check the .tar.gz that will be released to CRAN.
- [ ] `git fetch upstream && git checkout release-X.X.X-rcXX && git clean -f -d`
- [ ] Run `make build`. This copies Arrow C++ into tools/cpp, prunes some
unnecessary components, and runs `R CMD build` to generate the source tarball.
Because this will install the package, you will need to ensure that the version
of Arrow C++ available to the configure script is the same as the version
that is vendored into the R package (e.g., you may need to unset `ARROW_HOME`).
- [ ] `devtools::check_built("arrow_X.X.X.tar.gz")` locally
- [ ] Run reverse dependency checks. Currently this is a
[manual process](https://gist.github.com/paleolimbot/630fdab1e204d70fea97633d8fa15ccb);
however, in the future it may be a crossbow nightly job.
Wait for the official release...
- [ ] Release vote passed!
- [ ] If the release candidate commit updated, rebase the CRAN release branch
on that commit.
- [ ] Pick any commits that were made to main since the release commit that
were needed to fix CRAN-related submission issues identified in the above
steps.
- [ ] Remove badges from README.md
- [ ] Run `urlchecker::url_check()` on the R directory
- [ ] Create a PR entitled `WIP: [R] Verify CRAN release-10.0.1-rc0`. Add
a comment `@github-actions crossbow submit --group r` to run all R crossbow
jobs against the CRAN-specific release branch.
- [ ] Regenerate arrow_X.X.X.tar.gz (i.e., `make build`)
Create new autobrew and r-windows PRs such that they use the *release*
instead of the *release candidate*; ensure linux binary packages are available:
- [ ] PR into autobrew/homebrew-core (apache-arrow autobrew formula)
- [ ] PR into autobrew/homebrew-core (apache-arrow-static autobrew formula)
- [ ] PR into autobrew/scripts
- [ ] PR into r-windows/rtools-packages
- [ ] Ensure linux binaries are available in the artifactory:
https://apache.jfrog.io/ui/repos/tree/General/arrow/r
Check binary Arrow C++ distributions specific to the R package:
- [ ] Upload the .tar.gz to [win-builder](https://win-builder.r-project.org/upload.aspx) (r-devel only)
and confirm (with Nic, who will automatically receive an email about the results) that the check is clean.
This step cannot be completed before Jeroen has put the binaries in the MinGW repository, i.e. [here](https://ftp.opencpu.org/rtools/ucrt64/), [here](https://ftp.opencpu.org/rtools/mingw64/), and [here](https://ftp.opencpu.org/rtools/mingw32/).
- [ ] Upload the .tar.gz to [MacBuilder](https://mac.r-project.org/macbuilder/submit.html)
and confirm that the check is clean
- [ ] Check `install.packages("arrow_X.X.X.tar.gz")` on Ubuntu and ensure that the
hosted binaries are used
- [ ] `devtools::check_built("arrow_X.X.X.tar.gz")` locally one more time (for luck)
Submit!
- [ ] Upload arrow_X.X.X.tar.gz to the
[CRAN submit page](https://xmpalantir.wu.ac.at/cransubmit/)
- [ ] Confirm the submission email
Wait for CRAN...
- [ ] Accepted!
- [ ] Tag the tip of the CRAN-specific release branch
- [ ] Add a new line to the matrix in the [backwards compatability job](https://github.com/apache/arrow/blob/main/dev/tasks/r/github.linux.arrow.version.back.compat.yml)
- [ ] (patch releases only) Update the package version in `ci/scripts/PKGBUILD`, `dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb`, `r/DESCRIPTION`, and `r/NEWS.md`
- [ ] (CRAN-only releases) Rebuild the docs with `pkgdown::build_site(examples = FALSE, lazy = TRUE, install = FALSE)` and submit a PR to [the `asf-site` branch of the docs site](https://github.com/apache/arrow-site) with the contents of `r/docs/news/index.html`.
- [ ] (CRAN-only releases) Bump the version number in `r/pkgdown/assets/versions.json`, and update this on the [the `asf-site` branch of the docs site](https://github.com/apache/arrow-site) too.
- [ ] Update the packaging checklist template to reflect any new realities of the
packaging process.
- [ ] Wait for CRAN-hosted binaries on the
[CRAN package page](https://cran.r-project.org/package=arrow) to reflect the
new version
- [ ] Tweet!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #35936: [R] CRAN packaging checklist for version 12.0.1
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #35936:
URL: https://github.com/apache/arrow/issues/35936#issuecomment-1587525099
We can avoid the error by using old "racc" (< 1.6.1).
Adding `Homebrew.install_gem! "racc", "1.5.2"` before https://github.com/autobrew/brew/blob/5d00bd3d9cdd6d73f9685e48fa30562fea1bf08d/Library/Homebrew/style.rb#L20 may fix it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on issue #35936: [R] CRAN packaging checklist for version 12.0.1
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on issue #35936:
URL: https://github.com/apache/arrow/issues/35936#issuecomment-1587493139
@kou There's Ruby-related failures on the version of apache-arrow that we build for MacOS 10.13 (required for CRAN). We probably have to patch our autobrew formula?
https://app.travis-ci.com/github/autobrew/homebrew-core/builds/263698748#L757 / https://github.com/autobrew/homebrew-core/pull/125
```
racc requires Ruby version >= 2.5.
Error: Failed to install/update the 'rubocop' gem.
==> Installing or updating 'parallel' gem
Successfully installed parallel-1.19.2
1 gem installed
==> Installing or updating 'rubocop' gem
Successfully installed unicode-display_width-1.8.0
Successfully installed ruby-progressbar-1.13.0
Successfully installed rainbow-3.1.1
Successfully installed powerpack-0.1.3
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on issue #35936: [R] CRAN packaging checklist for version 12.0.1
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #35936:
URL: https://github.com/apache/arrow/issues/35936#issuecomment-1578711624
Tickets we need to cherry-pick across here:
- [ ] [0adf154](https://github.com/apache/arrow/commit/0adf154361346cdef2bd4731e3880ecddba4a2c2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic closed issue #35936: [R] CRAN packaging checklist for version 12.0.1
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed issue #35936: [R] CRAN packaging checklist for version 12.0.1
URL: https://github.com/apache/arrow/issues/35936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org