You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "leerho (via GitHub)" <gi...@apache.org> on 2023/12/17 19:28:32 UTC

[PR] Remove duplicate code (datasketches-java)

leerho opened a new pull request, #485:
URL: https://github.com/apache/datasketches-java/pull/485

   I'm trying to do the next set of updates in smaller batches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


Re: [PR] Remove duplicate code (datasketches-java)

Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #485:
URL: https://github.com/apache/datasketches-java/pull/485


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


Re: [PR] Remove duplicate code (datasketches-java)

Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #485:
URL: https://github.com/apache/datasketches-java/pull/485#discussion_r1432034939


##########
src/main/java/org/apache/datasketches/kll/KllHelper.java:
##########
@@ -806,31 +707,32 @@ private static long intCapAux(final int k, final int depth) {
   /**
    * Performs the integer based calculation of an individual level (or folded level).
    * @param k the configured k of the sketch
-   * @param depth depth the zero-based index of the level being computed.
+   * @param depth the zero-based index of the level being computed. The max depth is 30!

Review Comment:
   do we need "!" in docs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org