You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/01 06:02:43 UTC
[GitHub] [flink] paul8263 opened a new pull request #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
paul8263 opened a new pull request #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735
## What is the purpose of the change
Fix variable name typos in TaskInformation.java and Task.java
## Brief change log
* TaskInformation: Changed maxNumberOfSubtaks to maxNumberOfSubtasks, with its relative get method. Changed the maxNumberOfSubtaks in its constructor parameter to maxNumberOfSubtasks.
* Task: Correspondingly changed taskInformation.getMaxNumberOfSubtaks() to taskInformation.getMaxNumberOfSubtasks().
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): (no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] paul8263 commented on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
paul8263 commented on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570141816
Sorry for pushing the wrong commit to master branch. Now I corrected my commit, by keeping it the head of my master branch. The correct commit should be fa6bd89.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570028288
<!--
Meta data
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142788492 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142831077 TriggerType:PUSH TriggerID:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf
Hash:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4028 TriggerType:PUSH TriggerID:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf
-->
## CI report:
* fa6bd8979b2404913c658fc035746f7b2ddbd3ae Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142788492) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020)
* 904feac2ab81384f6faf2d6e7b53c4c24b1f63bf Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142831077) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4028)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570028288
<!--
Meta data
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142788492 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf
-->
## CI report:
* fa6bd8979b2404913c658fc035746f7b2ddbd3ae Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142788492) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020)
* 904feac2ab81384f6faf2d6e7b53c4c24b1f63bf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570028288
<!--
Meta data
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142788492 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
-->
## CI report:
* fa6bd8979b2404913c658fc035746f7b2ddbd3ae Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142788492) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570026137
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fa6bd8979b2404913c658fc035746f7b2ddbd3ae (Wed Jan 01 06:05:26 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570028288
<!--
Meta data
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142788492 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142831077 TriggerType:PUSH TriggerID:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf
Hash:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4028 TriggerType:PUSH TriggerID:904feac2ab81384f6faf2d6e7b53c4c24b1f63bf
-->
## CI report:
* fa6bd8979b2404913c658fc035746f7b2ddbd3ae Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142788492) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020)
* 904feac2ab81384f6faf2d6e7b53c4c24b1f63bf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142831077) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4028)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570028288
<!--
Meta data
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142788492 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
-->
## CI report:
* fa6bd8979b2404913c658fc035746f7b2ddbd3ae Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142788492) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570028288
<!--
Meta data
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
-->
## CI report:
* fa6bd8979b2404913c658fc035746f7b2ddbd3ae UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10735: [hotfix][runtime] Fix variable name typos in TaskInformation.java and…
URL: https://github.com/apache/flink/pull/10735#issuecomment-570028288
<!--
Meta data
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
Hash:fa6bd8979b2404913c658fc035746f7b2ddbd3ae Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142788492 TriggerType:PUSH TriggerID:fa6bd8979b2404913c658fc035746f7b2ddbd3ae
-->
## CI report:
* fa6bd8979b2404913c658fc035746f7b2ddbd3ae Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142788492) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4020)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services