You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2020/04/16 15:47:00 UTC

[impala] 01/04: IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit e863bac074f70b9d063cd7e53e46b3065b99edcb
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Wed Apr 15 11:38:23 2020 +0200

    IMPALA-9617: Skip tests that use Hive on non-HDFS filesystems
    
    Some tests are flaky due to timeouts in Hive queries on non-HDFS
    filesystems. Until IMPALA-9365 is resolved we only run these tests
    when the target filesystem is HDFS.
    
    Change-Id: I50fe92801e6e0f0ad8e169ec91ca4a8530088b7f
    Reviewed-on: http://gerrit.cloudera.org:8080/15736
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_mt_dop.py        | 3 +++
 tests/query_test/test_nested_types.py  | 7 +++++++
 tests/query_test/test_scanners.py      | 4 +++-
 tests/query_test/test_scanners_fuzz.py | 4 +++-
 4 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/tests/query_test/test_mt_dop.py b/tests/query_test/test_mt_dop.py
index da32e6f..98a3a3c 100644
--- a/tests/query_test/test_mt_dop.py
+++ b/tests/query_test/test_mt_dop.py
@@ -26,6 +26,7 @@ from tests.common.impala_test_suite import ImpalaTestSuite
 from tests.common.kudu_test_suite import KuduTestSuite
 from tests.common.skip import SkipIfABFS, SkipIfEC, SkipIfNotHdfsMinicluster
 from tests.common.test_vector import ImpalaTestDimension
+from tests.util.filesystem_utils import IS_HDFS
 
 WAIT_TIME_MS = build_flavor_timeout(60000, slow_build_timeout=100000)
 
@@ -68,6 +69,8 @@ class TestMtDop(ImpalaTestSuite):
         "create external table %s like functional_hbase.alltypes" % fq_table_name)
       expected_results = "Updated 1 partition(s) and 13 column(s)."
     elif HIVE_MAJOR_VERSION == 3 and file_format == 'orc':
+      # TODO: Enable this test on non-HDFS filesystems once IMPALA-9365 is resolved.
+      if not IS_HDFS: pytest.skip()
       self.run_stmt_in_hive(
           "create table %s like functional_orc_def.alltypes" % fq_table_name)
       self.run_stmt_in_hive(
diff --git a/tests/query_test/test_nested_types.py b/tests/query_test/test_nested_types.py
index dba4dee..c95e082 100644
--- a/tests/query_test/test_nested_types.py
+++ b/tests/query_test/test_nested_types.py
@@ -220,6 +220,13 @@ class TestNestedTypesNoMtDop(ImpalaTestSuite):
     self.run_test_case('QueryTest/nested-types-basic-partitioned', vector,
         unique_database)
 
+  # Skip this test on non-HDFS filesystems, because the test contains Hive
+  # queries that hang in some cases due to IMPALA-9365.
+  @SkipIfABFS.hive
+  @SkipIfADLS.hive
+  @SkipIfIsilon.hive
+  @SkipIfLocal.hive
+  @SkipIfS3.hive
   @SkipIfHive2.acid
   def test_partitioned_table_acid(self, vector, unique_database):
     """IMPALA-6370: Test that a partitioned table with nested types can be scanned."""
diff --git a/tests/query_test/test_scanners.py b/tests/query_test/test_scanners.py
index 9287071..62255ad 100644
--- a/tests/query_test/test_scanners.py
+++ b/tests/query_test/test_scanners.py
@@ -55,7 +55,7 @@ from tests.common.test_result_verifier import (
     QueryTestResult,
     parse_result_rows)
 from tests.common.test_vector import ImpalaTestDimension
-from tests.util.filesystem_utils import WAREHOUSE, get_fs_path
+from tests.util.filesystem_utils import IS_HDFS, WAREHOUSE, get_fs_path
 from tests.util.hdfs_util import NAMENODE
 from tests.util.get_parquet_metadata import get_parquet_metadata
 from tests.util.parse_util import get_bytes_summary_stats_counter
@@ -203,6 +203,8 @@ class TestUnmatchedSchema(ImpalaTestSuite):
     self._drop_test_table(vector)
     file_format = vector.get_value('table_format').file_format
     if file_format == 'orc':
+      # TODO: Enable this test on non-HDFS filesystems once IMPALA-9365 is resolved.
+      if not IS_HDFS: pytest.skip()
       db_name = "functional" + vector.get_value('table_format').db_suffix()
       self.run_stmt_in_hive(
           "create table %s.jointbl_test like functional.jointbl "
diff --git a/tests/query_test/test_scanners_fuzz.py b/tests/query_test/test_scanners_fuzz.py
index a4b16c1..73d734b 100644
--- a/tests/query_test/test_scanners_fuzz.py
+++ b/tests/query_test/test_scanners_fuzz.py
@@ -28,7 +28,7 @@ from subprocess import check_call
 from tests.common.environ import HIVE_MAJOR_VERSION
 from tests.common.test_dimensions import create_exec_option_dimension_from_dict
 from tests.common.impala_test_suite import ImpalaTestSuite, LOG
-from tests.util.filesystem_utils import WAREHOUSE, get_fs_path
+from tests.util.filesystem_utils import IS_HDFS, WAREHOUSE, get_fs_path
 from tests.util.test_file_parser import QueryTestSectionReader
 
 # Random fuzz testing of HDFS scanners. Existing tables for any HDFS file format
@@ -176,6 +176,8 @@ class TestScannersFuzzing(ImpalaTestSuite):
 
     table_format = vector.get_value('table_format')
     if HIVE_MAJOR_VERSION == 3 and table_format.file_format == 'orc':
+      # TODO: Enable this test on non-HDFS filesystems once IMPALA-9365 is resolved.
+      if not IS_HDFS: pytest.skip()
       self.run_stmt_in_hive("create table %s.%s like %s.%s" % (fuzz_db, fuzz_table,
           src_db, src_table))
       self.run_stmt_in_hive("insert into %s.%s select * from %s.%s" % (fuzz_db,