You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (Created) (JIRA)" <ji...@apache.org> on 2012/02/18 06:07:59 UTC
[jira] [Created] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Improve delete marker handling in Import M/R jobs
-------------------------------------------------
Key: HBASE-5431
URL: https://issues.apache.org/jira/browse/HBASE-5431
Project: HBase
Issue Type: Sub-task
Components: mapreduce
Affects Versions: 0.94.0
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Minor
Fix For: 0.94.0
Import currently create a new Delete object for each delete KV found in a result object.
This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211208#comment-13211208 ]
Lars Hofhansl commented on HBASE-5431:
--------------------------------------
Yeah, we'd need to export/import memstoreTS as well. Amit has one more thing to worry about. :)
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5431:
---------------------------------
Attachment: 5431.txt
Simple patch.
The removed Delete constructor was added in 0.94 just for this case, so it's safe to remove it now.
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210832#comment-13210832 ]
Hadoop QA commented on HBASE-5431:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12515067/5431.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -136 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 158 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/987//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/987//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/987//console
This message is automatically generated.
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211681#comment-13211681 ]
Hudson commented on HBASE-5431:
-------------------------------
Integrated in HBase-TRUNK-security #117 (See [https://builds.apache.org/job/HBase-TRUNK-security/117/])
HBASE-5431 Improve delete marker handling in Import M/R jobs (Revision 1290955)
Result = FAILURE
larsh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211061#comment-13211061 ]
stack commented on HBASE-5431:
------------------------------
So, we output Deletes and then we output Deletes? We'll be changing the order of kvs that came in in the Result? Thats ok?
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211189#comment-13211189 ]
Lars Hofhansl commented on HBASE-5431:
--------------------------------------
You mean Puts, then Deletes I assume ...
Unless Amit messes things up this is correct w.r.t. timestamp ordering :)
In fact the only "correct" ordering would be to create a Put or Delete for each KV.
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5431:
---------------------------------
Status: Patch Available (was: Open)
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211202#comment-13211202 ]
stack commented on HBASE-5431:
------------------------------
bq. In fact the only "correct" ordering would be to create a Put or Delete for each KV.
Yeah. I was wondering about this.
OK. +1.
For Amit's patch, if we switched on his facility, then we'd export with memstorets? Though I suppose that'd be no good at import time?
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-5431:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk, thanks for the review stack.
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5431) Improve delete marker handling in
Import M/R jobs
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211191#comment-13211191 ]
Lars Hofhansl commented on HBASE-5431:
--------------------------------------
That is to say, because all KV are timestamped they can be collected and applied in bulk (in the same way that Replication does it).
> Improve delete marker handling in Import M/R jobs
> -------------------------------------------------
>
> Key: HBASE-5431
> URL: https://issues.apache.org/jira/browse/HBASE-5431
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5431.txt
>
>
> Import currently create a new Delete object for each delete KV found in a result object.
> This can be improved with the new Delete API that allows adding a delete KV to a Delete object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira