You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2018/09/22 23:53:52 UTC
JCommander(java.lang.Object,java.lang.String...) has been deprecated
There is a new deprecation warning in Avatica. We try to keep these to zero.
Kevin, It was probably your CALCITE-2486 change. Can you fix please?
> [INFO] Compiling 2 source files to /home/jhyde/regress/calcite-avatica/standalone-server/target/classes
> [WARNING] /home/jhyde/regress/calcite-avatica/standalone-server/src/main/java/org/apache/calcite/avatica/standalone/StandaloneServer.java:[99,21] JCommander(java.lang.Object,java.lang.String...) in com.beust.jcommander.JCommander has been deprecated
> [INFO]
Re: JCommander(java.lang.Object,java.lang.String...) has been deprecated
Posted by Julian Hyde <jh...@gmail.com>.
Thank you!
Julian
> On Sep 22, 2018, at 19:49, Kevin Risden <kr...@apache.org> wrote:
>
> I found that for Avatica it looks like we can enable deprecation checks
> once we regenerate the protobuf files (which should have happened when
> protobuf was updated to 3.6.1). I filed CALCITE-2587 to look into that. In
> the meantime, fixed the JCommander deprecation warnings with commit 146d310.
>
> Kevin Risden
>
>
>> On Sat, Sep 22, 2018 at 10:21 PM Julian Hyde <jh...@apache.org> wrote:
>>
>> Yes, my nightly build script looks for deprecation warnings. (It’s only
>> active on JDK 9 and higher, because the “suppress” annotation doesn’t work
>> on JDK 8, and we have some uses of deprecated APIs — such as implementing
>> interfaces — that we cannot remove.)
>>
>>> On Sep 22, 2018, at 5:22 PM,
>> Kevin Risden
>> <kr...@apache.org> wrote:
>>>
>>> I can take a look.
>>>
>>> How did you find the warning other than reading the build output?
>>>
>>> Not sure if there is a flag we can set during compiling that would fail
>> the
>>> build for issues like these.
>>>
>>> Kevin Risden
>>>
>>>> On Sat, Sep 22, 2018, 19:54 Julian Hyde <jh...@apache.org> wrote:
>>>>
>>>> There is a new deprecation warning in Avatica. We try to keep these to
>>>> zero.
>>>>
>>>> Kevin, It was probably your CALCITE-2486 change. Can you fix please?
>>>>
>>>>> [INFO] Compiling 2 source files to
>>>> /home/jhyde/regress/calcite-avatica/standalone-server/target/classes
>>>>> [WARNING]
>>>>
>> /home/jhyde/regress/calcite-avatica/standalone-server/src/main/java/org/apache/calcite/avatica/standalone/StandaloneServer.java:[99,21]
>>>> JCommander(java.lang.Object,java.lang.String...) in
>>>> com.beust.jcommander.JCommander has been deprecated
>>>>> [INFO]
>>>>
>>
>>
Re: JCommander(java.lang.Object,java.lang.String...) has been deprecated
Posted by Kevin Risden <kr...@apache.org>.
I found that for Avatica it looks like we can enable deprecation checks
once we regenerate the protobuf files (which should have happened when
protobuf was updated to 3.6.1). I filed CALCITE-2587 to look into that. In
the meantime, fixed the JCommander deprecation warnings with commit 146d310.
Kevin Risden
On Sat, Sep 22, 2018 at 10:21 PM Julian Hyde <jh...@apache.org> wrote:
> Yes, my nightly build script looks for deprecation warnings. (It’s only
> active on JDK 9 and higher, because the “suppress” annotation doesn’t work
> on JDK 8, and we have some uses of deprecated APIs — such as implementing
> interfaces — that we cannot remove.)
>
> > On Sep 22, 2018, at 5:22 PM,
> Kevin Risden
> <kr...@apache.org> wrote:
> >
> > I can take a look.
> >
> > How did you find the warning other than reading the build output?
> >
> > Not sure if there is a flag we can set during compiling that would fail
> the
> > build for issues like these.
> >
> > Kevin Risden
> >
> > On Sat, Sep 22, 2018, 19:54 Julian Hyde <jh...@apache.org> wrote:
> >
> >> There is a new deprecation warning in Avatica. We try to keep these to
> >> zero.
> >>
> >> Kevin, It was probably your CALCITE-2486 change. Can you fix please?
> >>
> >>> [INFO] Compiling 2 source files to
> >> /home/jhyde/regress/calcite-avatica/standalone-server/target/classes
> >>> [WARNING]
> >>
> /home/jhyde/regress/calcite-avatica/standalone-server/src/main/java/org/apache/calcite/avatica/standalone/StandaloneServer.java:[99,21]
> >> JCommander(java.lang.Object,java.lang.String...) in
> >> com.beust.jcommander.JCommander has been deprecated
> >>> [INFO]
> >>
>
>
Re: JCommander(java.lang.Object,java.lang.String...) has been
deprecated
Posted by Julian Hyde <jh...@apache.org>.
Yes, my nightly build script looks for deprecation warnings. (It’s only active on JDK 9 and higher, because the “suppress” annotation doesn’t work on JDK 8, and we have some uses of deprecated APIs — such as implementing interfaces — that we cannot remove.)
> On Sep 22, 2018, at 5:22 PM, Kevin Risden <kr...@apache.org> wrote:
>
> I can take a look.
>
> How did you find the warning other than reading the build output?
>
> Not sure if there is a flag we can set during compiling that would fail the
> build for issues like these.
>
> Kevin Risden
>
> On Sat, Sep 22, 2018, 19:54 Julian Hyde <jh...@apache.org> wrote:
>
>> There is a new deprecation warning in Avatica. We try to keep these to
>> zero.
>>
>> Kevin, It was probably your CALCITE-2486 change. Can you fix please?
>>
>>> [INFO] Compiling 2 source files to
>> /home/jhyde/regress/calcite-avatica/standalone-server/target/classes
>>> [WARNING]
>> /home/jhyde/regress/calcite-avatica/standalone-server/src/main/java/org/apache/calcite/avatica/standalone/StandaloneServer.java:[99,21]
>> JCommander(java.lang.Object,java.lang.String...) in
>> com.beust.jcommander.JCommander has been deprecated
>>> [INFO]
>>
Re: JCommander(java.lang.Object,java.lang.String...) has been deprecated
Posted by Kevin Risden <kr...@apache.org>.
I can take a look.
How did you find the warning other than reading the build output?
Not sure if there is a flag we can set during compiling that would fail the
build for issues like these.
Kevin Risden
On Sat, Sep 22, 2018, 19:54 Julian Hyde <jh...@apache.org> wrote:
> There is a new deprecation warning in Avatica. We try to keep these to
> zero.
>
> Kevin, It was probably your CALCITE-2486 change. Can you fix please?
>
> > [INFO] Compiling 2 source files to
> /home/jhyde/regress/calcite-avatica/standalone-server/target/classes
> > [WARNING]
> /home/jhyde/regress/calcite-avatica/standalone-server/src/main/java/org/apache/calcite/avatica/standalone/StandaloneServer.java:[99,21]
> JCommander(java.lang.Object,java.lang.String...) in
> com.beust.jcommander.JCommander has been deprecated
> > [INFO]
>