You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/10 08:09:42 UTC

[GitHub] [rocketmq] zhanxuefeng opened a new pull request, #4274: Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

zhanxuefeng opened a new pull request, #4274:
URL: https://github.com/apache/rocketmq/pull/4274

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   Fix DLedgerRpcNettyService can not communicate with each other when tls enabled
   [ISSUE #4273](https://github.com/apache/rocketmq/issues/4273)
   
   ## Brief changelog
   
   NettyRemotingClient load the tls conf from system properties
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhanxuefeng commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by GitBox <gi...@apache.org>.
zhanxuefeng commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1153399917

   > Can you re-trigger ci test? @zhanxuefeng
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1150615440

   
   [![Coverage Status](https://coveralls.io/builds/49866831/badge)](https://coveralls.io/builds/49866831)
   
   Coverage decreased (-0.1%) to 52.096% when pulling **4a0f25875f707e42a6b92c3071d3c8ba309abe5c on zhanxuefeng:dledger** into **73b9ac82bcd14b2a40ba31888a96e62d06d42d92 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] github-actions[bot] commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1701931829

   This PR was closed because it has been inactive for 3 days since being marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1150588735

   Can you re-trigger ci test? @zhanxuefeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] github-actions[bot] commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1696585777

   This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1150615449

   
   [![Coverage Status](https://coveralls.io/builds/49866831/badge)](https://coveralls.io/builds/49866831)
   
   Coverage decreased (-0.1%) to 52.096% when pulling **4a0f25875f707e42a6b92c3071d3c8ba309abe5c on zhanxuefeng:dledger** into **73b9ac82bcd14b2a40ba31888a96e62d06d42d92 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] hzh0425 commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1122128486

   Oh, what a careful discovery.
   For optino 'useTLS' of NettyClientConfig, the configuration in BrokerStartup # createBrokerController is as follows:
   ![image](https://user-images.githubusercontent.com/58988019/167591891-d770f80a-ad1a-48c6-98a9-377b159c8def.png)
   But Dledger # DledgerRpcNettyService directly ignores this option, it should be missed, in addition to this pr, maybe you should initiate a pr in the dledger community to supplement.
   ![image](https://user-images.githubusercontent.com/58988019/167592213-bd7d70c9-1431-4af2-b462-69af41585e33.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4274:
URL: https://github.com/apache/rocketmq/pull/4274#issuecomment-1122985891

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4274?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4274](https://codecov.io/gh/apache/rocketmq/pull/4274?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c46db14) into [develop](https://codecov.io/gh/apache/rocketmq/commit/446b76b07b4336ec720b518ef2e9964bff650934?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (446b76b) will **increase** coverage by `0.50%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4274      +/-   ##
   =============================================
   + Coverage      47.61%   48.12%   +0.50%     
   - Complexity      4958     5074     +116     
   =============================================
     Files            633      642       +9     
     Lines          42577    42780     +203     
     Branches        5589     5599      +10     
   =============================================
   + Hits           20273    20586     +313     
   + Misses         19796    19678     -118     
   - Partials        2508     2516       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4274?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `46.04% <0.00%> (-0.57%)` | :arrow_down: |
   | [...broker/processor/AbstractSendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0Fic3RyYWN0U2VuZE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `40.62% <0.00%> (-8.68%)` | :arrow_down: |
   | [...he/rocketmq/remoting/protocol/RemotingCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JlbW90aW5nQ29tbWFuZC5qYXZh) | `72.45% <0.00%> (-6.18%)` | :arrow_down: |
   | [...in/java/org/apache/rocketmq/test/util/MQAdmin.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW4uamF2YQ==) | `38.88% <0.00%> (-5.56%)` | :arrow_down: |
   | [...g/apache/rocketmq/remoting/netty/NettyEncoder.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5RW5jb2Rlci5qYXZh) | `46.15% <0.00%> (-3.85%)` | :arrow_down: |
   | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: |
   | [...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh) | `34.83% <0.00%> (-2.25%)` | :arrow_down: |
   | [...n/java/org/apache/rocketmq/store/RunningFlags.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1J1bm5pbmdGbGFncy5qYXZh) | `31.11% <0.00%> (-2.23%)` | :arrow_down: |
   | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `14.96% <0.00%> (-1.37%)` | :arrow_down: |
   | [...cketmq/remoting/protocol/RocketMQSerializable.java](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL3Byb3RvY29sL1JvY2tldE1RU2VyaWFsaXphYmxlLmphdmE=) | `85.12% <0.00%> (-1.34%)` | :arrow_down: |
   | ... and [78 more](https://codecov.io/gh/apache/rocketmq/pull/4274/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4274?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4274?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [446b76b...c46db14](https://codecov.io/gh/apache/rocketmq/pull/4274?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] github-actions[bot] closed pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4274: [ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled
URL: https://github.com/apache/rocketmq/pull/4274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org