You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/09/15 22:40:58 UTC
Review Request 25661: ClusterHostInfo host indexes should be
hostnames in download client configs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25661/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-7318
https://issues.apache.org/jira/browse/AMBARI-7318
Repository: ambari
Description
-------
We should replace host indexes in clusterHostInfo with real hostnames in ClientConfigResourceProvider the same way as it's done on agent side
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 366b5e1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 214bf10
Diff: https://reviews.apache.org/r/25661/diff/
Testing
-------
in progress
Thanks,
Dmitro Lisnichenko
Re: Review Request 25661: ClusterHostInfo host indexes should be
hostnames in download client configs
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25661/#review53516
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
<https://reviews.apache.org/r/25661/#comment93204>
There are some others not mentioned here. But the problem is other that we shouldn't hardcode that, it will broke _hosts feature in scope of Service Plugibility.
- Andrew Onischuk
On Sept. 15, 2014, 8:40 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25661/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 8:40 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-7318
> https://issues.apache.org/jira/browse/AMBARI-7318
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We should replace host indexes in clusterHostInfo with real hostnames in ClientConfigResourceProvider the same way as it's done on agent side
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 366b5e1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 214bf10
>
> Diff: https://reviews.apache.org/r/25661/diff/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 25661: ClusterHostInfo host indexes should be
hostnames in download client configs
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25661/
-----------------------------------------------------------
(Updated Sept. 17, 2014, 1:52 p.m.)
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-7318
https://issues.apache.org/jira/browse/AMBARI-7318
Repository: ambari
Description
-------
We should replace host indexes in clusterHostInfo with real hostnames in ClientConfigResourceProvider the same way as it's done on agent side
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 366b5e1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 214bf10
Diff: https://reviews.apache.org/r/25661/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [3.579s]
[INFO] Ambari Server ..................................... SUCCESS [18:28.477s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:32.851s
[INFO] Finished at: Tue Sep 16 00:00:00 FET 2014
[INFO] Final Memory: 23M/275M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 25661: ClusterHostInfo host indexes should be
hostnames in download client configs
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25661/#review53674
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Sept. 17, 2014, 1:45 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25661/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2014, 1:45 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-7318
> https://issues.apache.org/jira/browse/AMBARI-7318
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We should replace host indexes in clusterHostInfo with real hostnames in ClientConfigResourceProvider the same way as it's done on agent side
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 366b5e1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 214bf10
>
> Diff: https://reviews.apache.org/r/25661/diff/
>
>
> Testing
> -------
>
> in progress
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 25661: ClusterHostInfo host indexes should be
hostnames in download client configs
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25661/
-----------------------------------------------------------
(Updated Sept. 17, 2014, 1:45 p.m.)
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-7318
https://issues.apache.org/jira/browse/AMBARI-7318
Repository: ambari
Description
-------
We should replace host indexes in clusterHostInfo with real hostnames in ClientConfigResourceProvider the same way as it's done on agent side
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 366b5e1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java 214bf10
Diff: https://reviews.apache.org/r/25661/diff/
Testing
-------
in progress
Thanks,
Dmitro Lisnichenko