You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/02/06 21:55:33 UTC

[kudu-CR] [fs manager-test] fix tests for macOS

Hello Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12383

to look at the new patch set (#2).

Change subject: [fs_manager-test] fix tests for macOS
......................................................................

[fs_manager-test] fix tests for macOS

As it turned out, it's been a since the fs_manager-test started
failing: in changelist b2f690d5 some changes were introduced
so one test started failing, and later on, with changelist 006937d3
the total number of failing tests on macOS grew up to three total.

The reason behind the failure is simple: on macOS the only
supported block manager is FileBlockManager and it doesn't support
many of operations exercised in the tests scenarios that started
failing.  This patch short-circuits those scenarios so they now
pass on macOS.

Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4
---
M src/kudu/fs/fs_manager-test.cc
1 file changed, 40 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/12383/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4
Gerrit-Change-Number: 12383
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)