You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/02/03 00:02:21 UTC
Re: Review Request 42186: Added tests for recovery for HTTP based
executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42186/#review117513
-----------------------------------------------------------
src/tests/slave_recovery_tests.cpp (line 420)
<https://reviews.apache.org/r/42186/#comment178702>
s/executor/HTTP based executor/
src/tests/slave_recovery_tests.cpp (line 434)
<https://reviews.apache.org/r/42186/#comment178703>
Can you add a comment here on why you do this for posterity?
src/tests/slave_recovery_tests.cpp (line 460)
<https://reviews.apache.org/r/42186/#comment178704>
Add a TODO here to use a command http executor instead of the custom test http executor.
src/tests/slave_recovery_tests.cpp (line 462)
<https://reviews.apache.org/r/42186/#comment178705>
s/default/http/
src/tests/slave_recovery_tests.cpp (line 506)
<https://reviews.apache.org/r/42186/#comment178708>
Was surprised to see a TASK_FINISHED here instead of TASK_RUNNING. I commented on the dependent review to fix that. That should change this test slightly.
src/tests/slave_recovery_tests.cpp (line 1046)
<https://reviews.apache.org/r/42186/#comment178711>
I think you should start the slave with fixed id like in the above test, to ensure the executor tries to connect to the right endpoint.
src/tests/slave_recovery_tests.cpp (line 1072)
<https://reviews.apache.org/r/42186/#comment178709>
ditto. see above.
- Vinod Kone
On Jan. 27, 2016, 4:14 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42186/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 4:14 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
>
> Diff: https://reviews.apache.org/r/42186/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 42186: Added tests for recovery for HTTP based
executors.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Feb. 2, 2016, 11:02 p.m., Vinod Kone wrote:
> > src/tests/slave_recovery_tests.cpp, line 1046
> > <https://reviews.apache.org/r/42186/diff/4/?file=1222479#file1222479line1046>
> >
> > I think you should start the slave with fixed id like in the above test, to ensure the executor tries to connect to the right endpoint.
Fixed. I had not done so earlier since for recovery mode `cleanup`, the executor would be killed anyways.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42186/#review117513
-----------------------------------------------------------
On Feb. 3, 2016, 2:34 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42186/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 2:34 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66
>
> Diff: https://reviews.apache.org/r/42186/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>