You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Roberts (JIRA)" <de...@myfaces.apache.org> on 2007/11/08 00:23:50 UTC
[jira] Created: (TRINIDAD-805) PPR fails on IE if call onclick()
directly instead of triggering event
PPR fails on IE if call onclick() directly instead of triggering event
----------------------------------------------------------------------
Key: TRINIDAD-805
URL: https://issues.apache.org/jira/browse/TRINIDAD-805
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 1.2.3-core
Environment: IE (6 & 7)
Reporter: Martin Roberts
Priority: Minor
Calling onclick() method of a <tr:commandLink> from javascript to trigger a PPR fails in IE because the (global) event method is null and an IE-specific tweak in TrPage._autoSubmit tries to reference it.
Workaround is to create and fire a click event.
Here is the onclick specification from the generated page:
onclick="TrPage._autoSubmit('content:myPage','content:myLink',event,1);return false;"
The event object referred to there is null, because the onclick() was called from javascript rather than triggered by an event.
That calls through to Trinidad code from adf/jsLibs/Page.js:
TrPage._autoSubmit = function(formId, inputId, event, validateForm, params)
{
if (_agent.isIE)
{
// comments trimmed
if (event["type"] == "hidden") // Fails HERE.
event = window.event;
}
...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-805) PPR fails on IE if call onclick()
directly instead of triggering event
Posted by "Andrew Robinson (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540928 ]
Andrew Robinson commented on TRINIDAD-805:
------------------------------------------
I don't see how this is a bug. The on* methods are meant to handle events, not to be invoked directly
> PPR fails on IE if call onclick() directly instead of triggering event
> ----------------------------------------------------------------------
>
> Key: TRINIDAD-805
> URL: https://issues.apache.org/jira/browse/TRINIDAD-805
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.3-core
> Environment: IE (6 & 7)
> Reporter: Martin Roberts
> Priority: Minor
>
> Calling onclick() method of a <tr:commandLink> from javascript to trigger a PPR fails in IE because the (global) event method is null and an IE-specific tweak in TrPage._autoSubmit tries to reference it.
> Workaround is to create and fire a click event.
> Here is the onclick specification from the generated page:
> onclick="TrPage._autoSubmit('content:myPage','content:myLink',event,1);return false;"
> The event object referred to there is null, because the onclick() was called from javascript rather than triggered by an event.
> That calls through to Trinidad code from adf/jsLibs/Page.js:
> TrPage._autoSubmit = function(formId, inputId, event, validateForm, params)
> {
> if (_agent.isIE)
> {
> // comments trimmed
> if (event["type"] == "hidden") // Fails HERE.
> event = window.event;
> }
> ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-805) PPR fails on IE if call onclick()
directly instead of triggering event
Posted by "Martin Roberts (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540940 ]
Martin Roberts commented on TRINIDAD-805:
-----------------------------------------
Possibly so - I don't think I am contextualised enough to argue for/against this being a bug. Having raised the issue, however, I will put forward the point that the only other code in that method referencing the event ( _validateInput from Core.js) explicitly handles null events.
> PPR fails on IE if call onclick() directly instead of triggering event
> ----------------------------------------------------------------------
>
> Key: TRINIDAD-805
> URL: https://issues.apache.org/jira/browse/TRINIDAD-805
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Affects Versions: 1.2.3-core
> Environment: IE (6 & 7)
> Reporter: Martin Roberts
> Priority: Minor
>
> Calling onclick() method of a <tr:commandLink> from javascript to trigger a PPR fails in IE because the (global) event method is null and an IE-specific tweak in TrPage._autoSubmit tries to reference it.
> Workaround is to create and fire a click event.
> Here is the onclick specification from the generated page:
> onclick="TrPage._autoSubmit('content:myPage','content:myLink',event,1);return false;"
> The event object referred to there is null, because the onclick() was called from javascript rather than triggered by an event.
> That calls through to Trinidad code from adf/jsLibs/Page.js:
> TrPage._autoSubmit = function(formId, inputId, event, validateForm, params)
> {
> if (_agent.isIE)
> {
> // comments trimmed
> if (event["type"] == "hidden") // Fails HERE.
> event = window.event;
> }
> ...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.