You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2012/09/06 03:53:52 UTC

Review Request: OOZIE-739 a coord action fails because the uri points to a namenode that is not in whitelist. the E0901 error shows in the oozie.log, but not written to the database

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6936/
-----------------------------------------------------------

Review request for oozie.


Description
-------

Taking up the responsibility of this patch on behalf of Mohamed Battisha (Earlier review request https://reviews.apache.org/r/4204/).

Incorporated unaddressed comments


This addresses bug OOZIE-739.
    https://issues.apache.org/jira/browse/OOZIE-739


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1381453 
  trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1381453 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1381453 

Diff: https://reviews.apache.org/r/6936/diff/


Testing
-------

yes


Thanks,

Mona Chitnis


Re: Review Request: OOZIE-739 a coord action fails because the uri points to a namenode that is not in whitelist. the E0901 error shows in the oozie.log, but not written to the database

Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6936/#review11425
-----------------------------------------------------------


+1.. Can you attach the final patch to JIRA?

- Virag Kothari


On Sept. 12, 2012, 1:36 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6936/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2012, 1:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> Taking up the responsibility of this patch on behalf of Mohamed Battisha (Earlier review request https://reviews.apache.org/r/4204/).
> 
> Incorporated unaddressed comments
> 
> 
> This addresses bug OOZIE-739.
>     https://issues.apache.org/jira/browse/OOZIE-739
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1383669 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1383669 
> 
> Diff: https://reviews.apache.org/r/6936/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>


Re: Review Request: OOZIE-739 a coord action fails because the uri points to a namenode that is not in whitelist. the E0901 error shows in the oozie.log, but not written to the database

Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6936/
-----------------------------------------------------------

(Updated Sept. 12, 2012, 1:36 a.m.)


Review request for oozie.


Changes
-------

addressed Virag's comment. Adjusted testcase to not need additional functions in HAS.


Description
-------

Taking up the responsibility of this patch on behalf of Mohamed Battisha (Earlier review request https://reviews.apache.org/r/4204/).

Incorporated unaddressed comments


This addresses bug OOZIE-739.
    https://issues.apache.org/jira/browse/OOZIE-739


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1383669 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1383669 

Diff: https://reviews.apache.org/r/6936/diff/


Testing
-------

yes


Thanks,

Mona Chitnis


Re: Review Request: OOZIE-739 a coord action fails because the uri points to a namenode that is not in whitelist. the E0901 error shows in the oozie.log, but not written to the database

Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6936/#review11111
-----------------------------------------------------------



trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/6936/#comment23833>

    is this function which is only used for test cases required?
    
    Can we get away by adding the namenode to the whitelist config:
    
    conf.set (oozie.service.HAS.namenode.whitelist, ''Nodename")
    and then restarting the services using this conf
    
    


- Virag Kothari


On Sept. 6, 2012, 1:53 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6936/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 1:53 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> Taking up the responsibility of this patch on behalf of Mohamed Battisha (Earlier review request https://reviews.apache.org/r/4204/).
> 
> Incorporated unaddressed comments
> 
> 
> This addresses bug OOZIE-739.
>     https://issues.apache.org/jira/browse/OOZIE-739
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1381453 
>   trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1381453 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1381453 
> 
> Diff: https://reviews.apache.org/r/6936/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>