[GitHub] [shardingsphere] sandynz commented on issue #7010: PostgreSQL dedicated column missed in t_order cause GeneralDQLIT.assertExecuteQuery failed

[GitBox <gi...@apache.org>]

sandynz commented on issue #7010:
URL: https://github.com/apache/shardingsphere/issues/7010#issuecomment-683266478


   After some testing, I found solution 1 is not suitable, since added table columns will affect other test cases (columnCount assertion), there're too much related test cases need to update.
   
   Considering possible solution 2:
   If it could add columns before executing sql for every test case, and also drop columns after executing sql, the table structure change will be isolated to current test case.
   Example test case:
   ```
       <dql-test-case
               sql="SELECT * FROM t_order WHERE rule = ?::jsonb AND start_point=ST_GeographyFromText('SRID=4326;POINT('||?||' '||?||')') AND user_id = ? AND order_id = ?"
               column-create="CREATE EXTENSION postgis; ALTER TABLE t_order ADD COLUMN rule ...;"
               column-drop="ALTER TABLE t_order DROP COLUMN rule"
               db-types="PostgreSQL">
   ```
   `column-create` and `column-drop` are added attributes.
   
   It might need some underlying base classes change.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org