You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/19 08:27:20 UTC
[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #1010: MINIFICPP-1203 - Make cpplint ignore bison generated expression language code
hunyadi-dev opened a new pull request #1010:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1010
This is done to later enable cpplint for the whole project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1010: MINIFICPP-1203 - Make cpplint ignore bison generated expression language code
Posted by GitBox <gi...@apache.org>.
fgerlits commented on a change in pull request #1010:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1010#discussion_r579059255
##########
File path: extensions/expression-language/CPPLINT.cfg
##########
@@ -0,0 +1,7 @@
+set noparent
Review comment:
Why `noparent`? We don't want the settings in the root CPPLINT.cfg file to apply here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #1010: MINIFICPP-1203 - Make cpplint ignore bison generated expression language code
Posted by GitBox <gi...@apache.org>.
arpadboda commented on a change in pull request #1010:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1010#discussion_r595976991
##########
File path: extensions/expression-language/CPPLINT.cfg
##########
@@ -0,0 +1,7 @@
+set noparent
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1010: MINIFICPP-1203 - Make cpplint ignore bison generated expression language code
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #1010:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org