[GitHub] [zeppelin] jongyoul commented on a diff in pull request #4339: [Draft] [ZEPPELIN-5703] Support to run another notebook in notebook inline

[GitBox <gi...@apache.org>]

jongyoul commented on code in PR #4339:
URL: https://github.com/apache/zeppelin/pull/4339#discussion_r850055601


##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java:
##########
@@ -975,6 +975,9 @@ public void restart(String settingId, String user, String noteId) throws Interpr
 
   // restart in note page
   public void restart(String settingId, ExecutionContext executionContext) throws InterpreterException {
+    if (settingId == null || settingId.startsWith("__internal__")) {

Review Comment:
   How about adding comment to describe `__internal__`?
   ```suggestion
       // __internal__ is set by RunNotebookInterpreter
       if (settingId == null || settingId.startsWith("__internal__")) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org