You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/03/03 13:55:03 UTC
[GitHub] [libcloud] lln-ijinus opened a new pull request #1436: Fill
auth_user_info in v3 connection
lln-ijinus opened a new pull request #1436: Fill auth_user_info in v3 connection
URL: https://github.com/apache/libcloud/pull/1436
## Fill auth_user_info in OpenStack v3 auth
### Description
When changing the OS_AUTH_VERSION to '3.x_password' instead of '2.0_password', we lose the user id information. This information is important to link for example snapshots to the user that made them.
This PR offers to restore the auth_user_info when authenticate with OpenStackIdentity_3_0_Connection
### Status
ready for review
### Checklist (tick everything that applies)
- [ x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ x] Documentation
- [ x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami merged pull request #1436: Fill auth_user_info in
v3 connection
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1436: Fill auth_user_info in v3 connection
URL: https://github.com/apache/libcloud/pull/1436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1436: Fill auth_user_info in v3
connection
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1436: Fill auth_user_info in v3 connection
URL: https://github.com/apache/libcloud/pull/1436#issuecomment-594172202
Merged change into trunk.
Thanks again for your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io commented on issue #1436: Fill auth_user_info
in v3 connection
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1436: Fill auth_user_info in v3 connection
URL: https://github.com/apache/libcloud/pull/1436#issuecomment-593967641
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=h1) Report
> Merging [#1436](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/b1c329fe7709875177d8f250b83c7669810eb83a?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1436 +/- ##
=======================================
Coverage 86.17% 86.17%
=======================================
Files 370 370
Lines 77718 77718
Branches 7642 7642
=======================================
Hits 66974 66974
Misses 7853 7853
Partials 2891 2891
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/common/openstack\_identity.py](https://codecov.io/gh/apache/libcloud/pull/1436/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tbW9uL29wZW5zdGFja19pZGVudGl0eS5weQ==) | `77.15% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=footer). Last update [b1c329f...ce49cc6](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1436: Fill auth_user_info in v3
connection
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1436: Fill auth_user_info in v3 connection
URL: https://github.com/apache/libcloud/pull/1436#issuecomment-594084251
Thanks for the contribution.
It would also be good to add a test case for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] Kami commented on issue #1436: Fill auth_user_info in v3
connection
Posted by GitBox <gi...@apache.org>.
Kami commented on issue #1436: Fill auth_user_info in v3 connection
URL: https://github.com/apache/libcloud/pull/1436#issuecomment-594166503
I've added some tests for v3.x auth versions.
It looks like they weren't added when 3.x auth version support was initially implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [libcloud] codecov-io edited a comment on issue #1436: Fill
auth_user_info in v3 connection
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1436: Fill auth_user_info in v3 connection
URL: https://github.com/apache/libcloud/pull/1436#issuecomment-593967641
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=h1) Report
> Merging [#1436](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/libcloud/commit/b1c329fe7709875177d8f250b83c7669810eb83a?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #1436 +/- ##
==========================================
+ Coverage 86.17% 86.18% +<.01%
==========================================
Files 370 370
Lines 77718 77730 +12
Branches 7642 7645 +3
==========================================
+ Hits 66974 66992 +18
+ Misses 7853 7849 -4
+ Partials 2891 2889 -2
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [libcloud/common/openstack\_identity.py](https://codecov.io/gh/apache/libcloud/pull/1436/diff?src=pr&el=tree#diff-bGliY2xvdWQvY29tbW9uL29wZW5zdGFja19pZGVudGl0eS5weQ==) | `78.22% <100%> (+1.07%)` | :arrow_up: |
| [libcloud/test/common/test\_openstack\_identity.py](https://codecov.io/gh/apache/libcloud/pull/1436/diff?src=pr&el=tree#diff-bGliY2xvdWQvdGVzdC9jb21tb24vdGVzdF9vcGVuc3RhY2tfaWRlbnRpdHkucHk=) | `97.7% <76.47%> (-0.37%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=footer). Last update [b1c329f...256bf45](https://codecov.io/gh/apache/libcloud/pull/1436?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services