other/2656: Include files are not always installed with correct permissions.

[Curt Sampson <cj...@portal.ca>]

>Number:         2656
>Category:       other
>Synopsis:       Include files are not always installed with correct permissions.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Jul 21 15:40:01 PDT 1998
>Last-Modified:
>Originator:     cjs@portal.ca
>Organization:
apache
>Release:        1.3.0
>Environment:
NetBSD 1.3/i386; however should be reproducable on all machines.
>Description:
If the apache distribution is extracted by someone with umask 077, so that
src/include/* are not group/world readable, the install will install them
as not group/world readable. This is because it relies on setting the umask
before doing the install, rather than setting the permissions directly.
>How-To-Repeat:

>Fix:
*** Makefile.tmpl~      Tue May 12 04:52:11 1998
--- Makefile.tmpl       Tue Jul 21 14:50:58 1998
***************
*** 324,329 ****
--- 324,332 ----
        @osdir=`grep '^OSDIR=' $(TOP)/$(SRC)/Makefile.config | sed -e 's:^OSDIR=.*/os:os:'`; \
        echo "$(UMASK) 022; $(CP) $(TOP)/$(SRC)/$${osdir}/os.h $(includedir)/"; \
        $(UMASK) 022; $(CP) $(TOP)/$(SRC)/$${osdir}/os.h $(root)$(includedir)/
+       # The above umask won't work if the original files were extracted with umask 077.
+       echo 'chmod 444 $(root)$(includedir)/*'
+       chmod 444 $(root)$(includedir)/*
        @echo "<=== [include]"
  
  #   create an initial document root containing the Apache manual,
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <ap...@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]