You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/06 06:27:55 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #38051: [SPARK-37935][SQL] Eliminate separate error sub-classes fields

MaxGekk commented on code in PR #38051:
URL: https://github.com/apache/spark/pull/38051#discussion_r988596967


##########
core/src/main/scala/org/apache/spark/SparkThrowableHelper.scala:
##########
@@ -34,29 +34,29 @@ private[spark] object SparkThrowableHelper {
   val errorReader = new ErrorClassesJsonReader(
     Seq(Utils.getSparkClassLoader.getResource("error/error-classes.json")))
 
+  def getErrorSubClass(errorClass: String): String = {
+    errorClass.split('.').lastOption.orNull

Review Comment:
   I am going to remove this method because it is not used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org