You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/15 07:54:04 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2540: fs: Skip call fs_checkfd if fd < 3 in fs_fdopen

xiaoxiang781216 opened a new pull request #2540:
URL: https://github.com/apache/incubator-nuttx/pull/2540


   ## Summary
   since the stdin, stdout and stderr may initialize later
   in userspace if CONFIG_DEV_CONSOLE isn't enabled.
   Note: it isn't bigger issue here to skip the check because
   vfs will check the validation again in read and write syscall
   
   ## Impact
   Handle the usb console in a more standardized way
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #2540: fs: Skip call fs_checkfd if fd < 3 in fs_fdopen

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #2540:
URL: https://github.com/apache/incubator-nuttx/pull/2540


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2540: fs: Skip call fs_checkfd if fd < 3 in fs_fdopen

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2540:
URL: https://github.com/apache/incubator-nuttx/pull/2540#issuecomment-745296477


   Done, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2540: fs: Skip call fs_checkfd if fd < 3 in fs_fdopen

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2540:
URL: https://github.com/apache/incubator-nuttx/pull/2540#issuecomment-745179305


   ```
   vfs/fs_fdopen.c:270:10: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
     270 |   return ret;
         |          ^~~
   vfs/fs_fdopen.c:118:26: note: 'ret' was declared here
     118 |   int                    ret;
         |                          ^~~
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org