[GitHub] [druid] vogievetsky commented on a change in pull request #12093: Docs: add FILTER to sql query syntax

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #12093:
URL: https://github.com/apache/druid/pull/12093#discussion_r774259240



##########
File path: docs/querying/sql.md
##########
@@ -47,11 +47,11 @@ Druid SQL supports SELECT queries with the following structure:
 ```
 [ EXPLAIN PLAN FOR ]
 [ WITH tableName [ ( column1, column2, ... ) ] AS ( query ) ]
-SELECT [ ALL | DISTINCT ] { * | exprs }
+SELECT [ ALL | DISTINCT ] { * | exprs } [ FILTER ( WHERE expr ) ]

Review comment:
       I don't think this belongs in the query syntax description at all. It should be a section in the aggregation functions as it can only apply there. Have a look at how it is implemented on [Calcite's reference page](https://calcite.apache.org/docs/reference.html) (search for `FILTER (`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org