You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/01/17 13:01:06 UTC
[GitHub] [incubator-doris] zhengshengjun opened a new pull request #7784: [Bug] Consider backend status when more than one backends exists in same host #7783
zhengshengjun opened a new pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784
…ame host
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784#issuecomment-1016362565
Please rebase your code to fix conflict ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on a change in pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on a change in pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784#discussion_r790868647
##########
File path: fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
##########
@@ -871,6 +871,9 @@ public void releaseBackends(String clusterName, boolean isReplay) {
List<Backend> backends = Lists.newArrayList();
for (List<Backend> list : backendMaps.values()) {
if (FeConstants.runningUnitTest || Config.allow_replica_on_same_host) {
+ if (needAlive) {
Review comment:
Sorry for not having noticed the code have already changed too much, i have updated and tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784#issuecomment-1019298061
> hi @zhengshengjun thanks for your PR. Please rebase to solve the conflict
conflict resolved ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784#issuecomment-1017219247
hi @zhengshengjun thanks for your PR. Please rebase to solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784#discussion_r790200118
##########
File path: fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
##########
@@ -871,6 +871,9 @@ public void releaseBackends(String clusterName, boolean isReplay) {
List<Backend> backends = Lists.newArrayList();
for (List<Backend> list : backendMaps.values()) {
if (FeConstants.runningUnitTest || Config.allow_replica_on_same_host) {
+ if (needAlive) {
Review comment:
This block:
```
if (needAlive) {
list = list.stream().filter(Backend::isAlive).collect(Collectors.toList());
}
```
should be added to the following `else` clause:
```
} else {
if (needAlive) {
list = list.stream().filter(Backend::isAlive).collect(Collectors.toList());
}
Collections.shuffle(list);
backends.add(list.get(0));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784#issuecomment-1020250065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zhengshengjun commented on pull request #7784: [Bug] Consider backend status when more than one backends exists in same host
Posted by GitBox <gi...@apache.org>.
zhengshengjun commented on pull request #7784:
URL: https://github.com/apache/incubator-doris/pull/7784#issuecomment-1019301905
> Please rebase your code to fix conflict ~
Conflict resolved, could you please help me to check again ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org