You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/27 07:31:14 UTC

[GitHub] [spark] MichaelChirico opened a new pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

MichaelChirico opened a new pull request #28362:
URL: https://github.com/apache/spark/pull/28362


   ⚠️  this is a follow-up to https://github.com/apache/spark/pull/28350. That PR should be merged first then I'll rebase this
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   Combine `gapply`, `gapplyCollect`, `dapply`, and `dapplyCollect` in a single Rd. This will help simplify changes to the highly correlated documentation as well as make it easier for users to see related functions in a single location.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   https://issues.apache.org/jira/browse/SPARK-31570
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   
   Nothing in code, only in documentation
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Ran `roxygen2::roxygenise('.')` and examined the Rd output


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619792192


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619812405


   **[Test build #121889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121889/testReport)** for PR 28362 at commit [`e8c20cf`](https://github.com/apache/spark/commit/e8c20cf2f0959d43db94db19157ebd857df1bc52).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630626916






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630720658






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-663108844






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619819692


   **[Test build #121892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121892/testReport)** for PR 28362 at commit [`6ad2085`](https://github.com/apache/spark/commit/6ad20856a3b242bf7f139eaee10a98ceabadf29f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630577457






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-663078680


   **[Test build #126421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126421/testReport)** for PR 28362 at commit [`a557256`](https://github.com/apache/spark/commit/a557256d44b86fd4c9ddf66783938bf549d541d1).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619848483


   **[Test build #121892 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121892/testReport)** for PR 28362 at commit [`6ad2085`](https://github.com/apache/spark/commit/6ad20856a3b242bf7f139eaee10a98ceabadf29f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630778923






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630720658






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619791572


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619819692


   **[Test build #121892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121892/testReport)** for PR 28362 at commit [`6ad2085`](https://github.com/apache/spark/commit/6ad20856a3b242bf7f139eaee10a98ceabadf29f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619848709






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630575435


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MichaelChirico commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-725187474


   @HyukjinKwon could you help to revive this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619820262






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28362:
URL: https://github.com/apache/spark/pull/28362#discussion_r427157063



##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1652,34 +1607,43 @@ setMethod("dapplyCollect",
 
 #' gapply

Review comment:
       We could change something like "R native function execution". There are a lot of examples like this to group it in `functions.R`. Might be best to follow the way consistently.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619942415






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630626732


   **[Test build #122829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122829/testReport)** for PR 28362 at commit [`6ad2085`](https://github.com/apache/spark/commit/6ad20856a3b242bf7f139eaee10a98ceabadf29f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28362:
URL: https://github.com/apache/spark/pull/28362#discussion_r427158276



##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1652,34 +1607,43 @@ setMethod("dapplyCollect",
 
 #' gapply

Review comment:
       You can check the documentation build via `cd R && ./create-docs.sh && open pkg/html/index.html`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619808938


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630719965


   **[Test build #122846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122846/testReport)** for PR 28362 at commit [`77a0e95`](https://github.com/apache/spark/commit/77a0e95c8cf6777fe683793e12a7e7306663a6d0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630778923






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619942415






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630778746


   **[Test build #122846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122846/testReport)** for PR 28362 at commit [`77a0e95`](https://github.com/apache/spark/commit/77a0e95c8cf6777fe683793e12a7e7306663a6d0).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MichaelChirico commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630743034


   Error seems related to SBT, not this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630577030


   **[Test build #122829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122829/testReport)** for PR 28362 at commit [`6ad2085`](https://github.com/apache/spark/commit/6ad20856a3b242bf7f139eaee10a98ceabadf29f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619848709






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #28362:
URL: https://github.com/apache/spark/pull/28362#discussion_r427155885



##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1652,34 +1607,43 @@ setMethod("dapplyCollect",
 
 #' gapply

Review comment:
       Shall we update here too? Seems a bit odd that the short summary says gapply for dapply ones:
   ![Screen Shot 2020-05-19 at 6 16 03 PM](https://user-images.githubusercontent.com/6477701/82308852-529cba00-99fd-11ea-9321-d770e5a26242.png)
   ![Screen Shot 2020-05-19 at 6 16 15 PM](https://user-images.githubusercontent.com/6477701/82308860-54667d80-99fd-11ea-9c77-f0dbaff02cab.png)
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MichaelChirico commented on a change in pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on a change in pull request #28362:
URL: https://github.com/apache/spark/pull/28362#discussion_r427178276



##########
File path: R/pkg/R/DataFrame.R
##########
@@ -1652,34 +1607,43 @@ setMethod("dapplyCollect",
 
 #' gapply

Review comment:
       Thanks @HyukjinKwon , i went with `Functions to apply native R code on groups or partitions`. 
   
   Generally I think the Rd titles could go for a fresh pass overall (e.g. `cov` is not very descriptive and applies to a bevy of functions), but I'll leave that for another day.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630626916






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619791572


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MichaelChirico commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
MichaelChirico commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619816774


   @HyukjinKwon just merged vs master, ready to merge when you are 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630577457






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619809487






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-663079403






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619812405


   **[Test build #121889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121889/testReport)** for PR 28362 at commit [`e8c20cf`](https://github.com/apache/spark/commit/e8c20cf2f0959d43db94db19157ebd857df1bc52).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-663108844






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-663079403






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630719965


   **[Test build #122846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122846/testReport)** for PR 28362 at commit [`77a0e95`](https://github.com/apache/spark/commit/77a0e95c8cf6777fe683793e12a7e7306663a6d0).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619820262






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619940829


   **[Test build #121889 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121889/testReport)** for PR 28362 at commit [`e8c20cf`](https://github.com/apache/spark/commit/e8c20cf2f0959d43db94db19157ebd857df1bc52).
    * This patch passes all tests.
    * This patch **does not merge cleanly**.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-663078680


   **[Test build #126421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126421/testReport)** for PR 28362 at commit [`a557256`](https://github.com/apache/spark/commit/a557256d44b86fd4c9ddf66783938bf549d541d1).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-663108483


   **[Test build #126421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126421/testReport)** for PR 28362 at commit [`a557256`](https://github.com/apache/spark/commit/a557256d44b86fd4c9ddf66783938bf549d541d1).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619792192


   Can one of the admins verify this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-619809487






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28362: [SPARK-31570][R][DOCS] R combine gapply dapply

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28362:
URL: https://github.com/apache/spark/pull/28362#issuecomment-630577030


   **[Test build #122829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122829/testReport)** for PR 28362 at commit [`6ad2085`](https://github.com/apache/spark/commit/6ad20856a3b242bf7f139eaee10a98ceabadf29f).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org