[GitHub] [flink] rkhachatryan commented on a change in pull request #19331: [FLINK-26985][runtime] Don't discard shared state of restored checkpoints

[GitBox <gi...@apache.org>]

rkhachatryan commented on a change in pull request #19331:
URL: https://github.com/apache/flink/pull/19331#discussion_r841064655



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java
##########
@@ -174,6 +181,15 @@ public void registerAll(
         }
     }
 
+    @Override
+    public void registerAllAfterRestored(CompletedCheckpoint checkpoint, RestoreMode mode) {
+        registerAll(checkpoint.getOperatorStates().values(), checkpoint.getCheckpointID());
+        if (mode != RestoreMode.CLAIM) {

Review comment:
       In `CLAIM` mode, the state of the checkpoints that the job is recovering from can be deleted (must be deleted).
   I'll add this comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org