You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/17 18:30:41 UTC

[GitHub] [camel-k] astefanutti opened a new pull request #2881: fix: Install Kamelets as unstructured resources

astefanutti opened a new pull request #2881:
URL: https://github.com/apache/camel-k/pull/2881


   This PR fixes an issue introduced with #2814, that removes nil objects from the apply patches, that are computed to install the Kamelets from the embedded catalog. This breaks Kamelets that use YAML DSL with empty objects, e.g.:  
   
   ```yaml
     flow:
       from:
         steps:
         - marshal:
             json: {}
   ```
   
   or:
   
   ```yaml
     flow:
       from:
         steps:
           - filter:
             steps:
               - stop: {}
   ```
   
   Positive patch is only needed when applying structured objects, whose initialised fields would take ownership even for non-managed fields. The "plain" patch can be used when applying unstructured objects. So the PR moves to installing the Kamelets as unstructured objects, so as to maintain the exact definition from the `.spec.flow` field, that's encoded as a `RawMessage` struct. 
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti merged pull request #2881: fix: Install Kamelets as unstructured resources

Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #2881:
URL: https://github.com/apache/camel-k/pull/2881


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org