[GitHub] [accumulo] ctubbsii commented on pull request #2427: Migrate accumulo-core module from JUnit 4 to JUnit 5

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #2427:
URL: https://github.com/apache/accumulo/pull/2427#issuecomment-1046326215


   All the ITs passed with the changes so far. I saw a few tests flake out a bit, because they were timing sensitive and the operation they were waiting on took slightly longer than expected, but they passed on subsequent runs. And, I think that happened because I had another build running on the same machine at the same time. I couldn't reproduce those failures.
   
   If you don't get to my suggestions above first, I may just make them myself, and merge this in. I don't want to risk this PR diverging further from the current passing state, with all the ITs passing and risking my absurdly time-consuming code review I just did on these 250 or so files getting stale. :smiley_cat:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org