[GitHub] [kafka] Hangleton commented on a diff in pull request #13526: KAFKA-14869: Bump coordinator Value records to flexible versions (KIP-915, Part-2)

["Hangleton (via GitHub)" <gi...@apache.org>]

Hangleton commented on code in PR #13526:
URL: https://github.com/apache/kafka/pull/13526#discussion_r1168399681


##########
group-coordinator/src/main/resources/common/message/GroupMetadataValue.json:
##########
@@ -16,8 +16,11 @@
 {
   "type": "data",
   "name": "GroupMetadataValue",
-  "validVersions": "0-3",
-  "flexibleVersions": "none",
+  // Version 4 is the first flexible version.
+  // KIP-915: bumping the version will no longer make this record backward compatible.
+  // We suggest to add/remove only tagged fields to maintain backward compatibility.
+  "validVersions": "0-4",

Review Comment:
   Maybe we could add a unit test which verifies that the version is never incremented above 4?



##########
group-coordinator/src/main/resources/common/message/OffsetCommitValue.json:
##########
@@ -16,8 +16,11 @@
 {
   "type": "data",
   "name": "OffsetCommitValue",
-  "validVersions": "0-3",
-  "flexibleVersions": "none",
+  // Version 4 is the first flexible version.
+  // KIP-915: bumping the version will no longer make this record backward compatible.
+  // We suggest to add/remove only tagged fields to maintain backward compatibility.
+  "validVersions": "0-4",

Review Comment:
   Ditto.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org