You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mowcixo <gi...@git.apache.org> on 2014/12/01 12:44:20 UTC
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
GitHub user mowcixo opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54
Better header parse with custom WSSE sintax
Changed the FileTransfer.cs#parseHeaders function to work with the changes of the https://github.com/apache/cordova-wp8/pull/62 pull request.
The problem is that, with WSSE headers with a VALUE like this:
```
UsernameToken Username="foo@bar.net", PasswordDigest="ZTQXXXXXXXXXXXXXXXXXXXXXXXXXXXX0NTJlMGE2M2I0NGJiYWM4NA==", Nonce="XXXXXXXXXXXXXXXXXXXXXXXXXXXXA==", Created="2014-10-11T18:48:07.232Z"
```
The current version of the function, will return null because of a bad parse by DataContractJsonSerializer. The pull request I mentioned suggests change DataContractJsonSerializer by Newtonsoft.Json for a better serialize and performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mowcixo/cordova-plugin-file-transfer develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 1d85f44b4ccc9ce404da97d00ea1decc19e59cf8
Author: Moisés Gramary Barbosa <mo...@webet.es>
Date: 2014-12-01T11:38:47Z
Changed the FileTransfer.cs#parseHeaders function to work with the changes of the https://github.com/apache/cordova-wp8/pull/62 pull request.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by mowcixo <gi...@git.apache.org>.
Github user mowcixo commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-86590240
I close this pull request in favor of apache/cordova-plugin-file-transfer#72.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99142847
Once apache/cordova-wp8#79 is included (and released) then we can include this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by mowcixo <gi...@git.apache.org>.
GitHub user mowcixo reopened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54
Better header parse with custom WSSE sintax
Changed the FileTransfer.cs#parseHeaders function to work with the changes of the https://github.com/apache/cordova-wp8/pull/62 pull request.
The problem is that, with WSSE headers with a VALUE like this:
```
UsernameToken Username="foo@bar.net", PasswordDigest="ZTQXXXXXXXXXXXXXXXXXXXXXXXXXXXX0NTJlMGE2M2I0NGJiYWM4NA==", Nonce="XXXXXXXXXXXXXXXXXXXXXXXXXXXXA==", Created="2014-10-11T18:48:07.232Z"
```
The current version of the function, will return null because of a bad parse by DataContractJsonSerializer. The pull request I mentioned suggests change DataContractJsonSerializer by Newtonsoft.Json for a better serialize and performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mowcixo/cordova-plugin-file-transfer develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 1d85f44b4ccc9ce404da97d00ea1decc19e59cf8
Author: Moisés Gramary Barbosa <mo...@webet.es>
Date: 2014-12-01T11:38:47Z
Changed the FileTransfer.cs#parseHeaders function to work with the changes of the https://github.com/apache/cordova-wp8/pull/62 pull request.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-146977684
Ping @mowcixo, thanks for your contribution!
Could you please update the commit message title to "CB-8721 Better header parse with custom WSSE syntax" (btw looks there is a typo "sintax" -> "syntax", could you please rename the PR title as well?) and include `plugin.xml` change with `engine` tag updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-147560508
I think this change is not relevant anymore because of this commit: https://github.com/apache/cordova-plugin-file-transfer/commit/e8ca110a3026b74276f762a81bb10c4a04ade4fe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99360986
This one is now possible since apache/cordova-wp8#62 has been integrated (I already tested building with apache/cordova-wp8#62 OK). Can we consider including this one again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by mowcixo <gi...@git.apache.org>.
Github user mowcixo closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99545354
Should the plugin.xml for this plugin be updated to specify that this version of the plugin now only will work with cordova-wp8 4.0 and greater? I believe you can use the `engine` tag to do so - http://cordova.apache.org/docs/en/5.0.0/plugin_ref_spec.md.html#Plugin%20Specification
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99575104
yes, these changes need to happen together, and the engine tag is how that is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99422459
> Great! Reopened!
>
> ...
> apache/cordova-wp8#79
> ...
Yes I meant apache/cordova-wp8#79 - my bad!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by mowcixo <gi...@git.apache.org>.
Github user mowcixo commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99387644
Great! Reopened!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: Better header parse wit...
Posted by brodybits <gi...@git.apache.org>.
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-99430542
> Great! Reopened!
Also I suggest we should mark this as a solution to CB-8721, both in the
title of this PR and in JIRA CB-8721 (see discussion in #82).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-8721 - Better header...
Posted by mowcixo <gi...@git.apache.org>.
Github user mowcixo commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/54#issuecomment-147072279
I've just changed the PR title, but I don't really know how to do the rest of things... sorry...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org