You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/09/06 19:00:21 UTC

[GitHub] [singa] moazreyad opened a new pull request #790: Remove Travis CI

moazreyad opened a new pull request #790:
URL: https://github.com/apache/singa/pull/790


   This PR removes Travis CI since we are using Github Actions now. :octocat:
   
   - We will not run the cpp and python lint commands:
   
   tool/linting/py.sh
   tool/linting/cpp.sh
   
   Instead we can just use the output of Github's lgtm. Is this fine with everyone?
   
   - We do not have a github workflow that publishes the conda packages. If this is required, we can add the [Conda Package Publish Action](https://github.com/marketplace/actions/conda-package-publish-action) at the end of the conda workflow. Assuming there is secrets.ANACONDA_PASSWORD and secrets.ANACONDA_USERNAME defined in the [github secrets](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) of the user who runs this workflow.
   
   - Currently the github workflows use the latest Ubuntu only. If it is required to support another older versions, we can add them to the workflow. Travis CI was checking Ubuntu 14.04, 16.04 and 18.04. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles merged pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
nudles merged pull request #790:
URL: https://github.com/apache/singa/pull/790


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles merged pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
nudles merged pull request #790:
URL: https://github.com/apache/singa/pull/790


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689958872


   I think I got the difference between "push" and "pull_request" clearer now:
   
   From this webpage: https://frontside.com/blog/2020-05-26-github-actions-pull_request/
   This page says that:
   "This difference means that a pull_request workflow ref would look like refs/remotes/pull/##/merge whereas a push workflow would be refs/heads/branch_name. This explains why the SHA of a push workflow matches the commit that triggered the workflow, whereas the SHA of a pull_request workflow does not; instead **the SHA of the pull_request is the resulting commit that was created from merging the base to the head**."


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688065275


   I have a question: the current CI use the current PR branch for CI test. 
   
   In this case, if one PR fixes a bug that cause a failed CI test, some other PR still cannot pass the test unless rebased to dev branch
   Also another problem is that if team members A and B working on the same branch, their code can pass the CI test separately, but may not be compatible to each other (e.g. due to API change)
   
   
   Would it be a better practice if we use the merged code instead of the PR branch for CI test?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris removed a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris removed a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688666652


   > > Would it be a better practice if we use the merged code instead of the PR branch for CI test?
   > 
   > It is possible to remove `pull_request:` from the trigger events in the [workflow yaml files](https://github.com/apache/singa/tree/dev/.github/workflows):
   > 
   > ```
   > on:
   >   push:
   >   pull_request:
   > ```
   > 
   > or we can keep it as a guide for the PR reviewer but not requiring all PR to pass all the tests. It will be up to the PR reviewer to decide if the failed tests should be fixed in this PR or not. I would propose to keep it because sometimes it is better to discover the failed tests in the PR before the merge. But all the team can vote on the best options for triggering the workflow. There are many [events for workflow trigger](https://docs.github.com/en/actions/reference/events-that-trigger-workflows) and may be some of them can be enabled on some specific workflows.
   > 
   > > Also another problem is that if team members A and B working on the same branch, their code can pass the CI test separately, but may not be compatible to each other (e.g. due to API change)
   > 
   > If the is enabled, this problem will be discovered when the second team member pushes the code and the workflow is triggered.
   
   Thanks a lot for the opinion. I also think that keeping all the test is good, as it helps us to safeguard the code base.
   
   I suggest using the merged code (i.e. the code merging from PR branch and dev branch) for CI test instead of using PR branch code only for CI test, the flow I suggest is something like this:
   Step 1: Merged_code = Merge (PR branch, base branch)
   Step 2: Test_result = CI_Test(Merged_code)
   Step 3: Make decision whether to merge the code based on Test_result.
   
   Maybe this is equivalent to the `push:` trigger but I am not sure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688065275


   I have a question: the current CI use the current PR branch for CI test. 
   
   In this case, if one PR fixes a bug that cause a failed CI test, some other PR still cannot pass the test unless rebased to dev branch
   
   Would it be a better practice if we use the merged code instead of the PR branch for CI test?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
nudles commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-690816957


   > 
   > 
   > This PR removes Travis CI since we are using Github Actions now. :octocat:
   > 
   >     * We will not run the cpp and python lint commands:
   > 
   > 
   > tool/linting/py.sh
   > tool/linting/cpp.sh
   > 
   > Instead we can just use the output of Github's lgtm. Is this fine with everyone?
   > 
   >     * We do not have a github workflow that publishes the conda packages. If this is required, we can add the [Conda Package Publish Action](https://github.com/marketplace/actions/conda-package-publish-action) at the end of the conda workflow. Assuming there is secrets.ANACONDA_PASSWORD and secrets.ANACONDA_USERNAME defined in the [github secrets](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) of the user who runs this workflow.
   > 
   
   How can we set the secrets? There is no `setting` tab for this project..
   
   >     * Currently the github workflows use the latest Ubuntu only. If it is required to support another older versions, we can add them to the workflow. Travis CI was checking Ubuntu 14.04, 16.04 and 18.04.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689439017


   Sometime don't know why only
   `Native-Ubuntu / build-cpptest-on-cpu (pull_request)`  is here below
   But 
   `Native-Ubuntu / build-cpptest-on-cpu (push)` is not here (e.g. in this PR)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689958872


   I think I got the difference between "push" and "pull_request" clearer now:
   
   From this webpage: https://frontside.com/blog/2020-05-26-github-actions-pull_request/
   This page says that:
   "This difference means that a pull_request workflow ref would look like `refs/remotes/pull/##/merge` whereas a push workflow would be `refs/heads/branch_name`. This explains why the SHA of a push workflow matches the commit that triggered the workflow, whereas the SHA of a pull_request workflow does not; instead **the SHA of the pull_request is the resulting commit that was created from merging the base to the head**."
   
   So the trigger of `pull_request` is very useful because it seems to use the merged code (from base to head) for test, which accounts for the compatibility to the base branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689958872


   I think I got the difference between "push" and "pull_request" clearer now:
   
   From this webpage: https://frontside.com/blog/2020-05-26-github-actions-pull_request/
   This page says that:
   "This difference means that a pull_request workflow ref would look like refs/remotes/pull/##/merge whereas a push workflow would be refs/heads/branch_name. This explains why the SHA of a push workflow matches the commit that triggered the workflow, whereas the SHA of a pull_request workflow does not; instead **the SHA of the pull_request is the resulting commit that was created from merging the base to the head**."
   
   So the trigger of pull_request is very useful because it seems to use the merged code (from base to head) for test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688065275


   I have a question: the current CI use the current PR branch for CI test. 
   
   In this case, if one PR fixes a bug that cause a failed CI test, some other PR still cannot pass the test unless rebased to dev branch
   
   Would it be a better practice if we use the merged branch instead of the PR branch for CI test?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689958872


   I think I got the difference between "push" and "pull_request" clearer now:
   
   From this webpage: https://frontside.com/blog/2020-05-26-github-actions-pull_request/
   This page says that:
   "This difference means that a pull_request workflow ref would look like refs/remotes/pull/##/merge whereas a push workflow would be refs/heads/branch_name. This explains why the SHA of a push workflow matches the commit that triggered the workflow, whereas the SHA of a pull_request workflow does not; instead **the SHA of the pull_request is the resulting commit that was created from merging the base to the head**."
   
   So the trigger of `pull_request` is very useful because it seems to use the merged code (from base to head) for test, which accounts for the compatibility to the base branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688666652


   > > Would it be a better practice if we use the merged code instead of the PR branch for CI test?
   > 
   > It is possible to remove `pull_request:` from the trigger events in the [workflow yaml files](https://github.com/apache/singa/tree/dev/.github/workflows):
   > 
   > ```
   > on:
   >   push:
   >   pull_request:
   > ```
   > 
   > or we can keep it as a guide for the PR reviewer but not requiring all PR to pass all the tests. It will be up to the PR reviewer to decide if the failed tests should be fixed in this PR or not. I would propose to keep it because sometimes it is better to discover the failed tests in the PR before the merge. But all the team can vote on the best options for triggering the workflow. There are many [events for workflow trigger](https://docs.github.com/en/actions/reference/events-that-trigger-workflows) and may be some of them can be enabled on some specific workflows.
   > 
   > > Also another problem is that if team members A and B working on the same branch, their code can pass the CI test separately, but may not be compatible to each other (e.g. due to API change)
   > 
   > If the is enabled, this problem will be discovered when the second team member pushes the code and the workflow is triggered.
   
   Thanks a lot for the opinion. I also think that keeping all the test is good, as it helps us to safeguard the code base.
   
   I suggest using the merged code (i.e. the code merging from PR branch and dev branch) for CI test instead of using PR branch code only for CI test, the flow I suggest is something like this:
   Step 1: Merged_code = Merge (PR branch, base branch)
   Step 2: Test_result = CI_Test(Merged_code)
   Step 3: Make decision whether to merge the code based on Test_result.
   
   Maybe this is equivalent to the `push:` trigger but I am not sure.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] moazreyad commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
moazreyad commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688280432


   > Would it be a better practice if we use the merged code instead of the PR branch for CI test?
   
   It is possible to remove `pull_request:` from the trigger events in the [workflow yaml files](https://github.com/apache/singa/tree/dev/.github/workflows):
   
   ```
   on:
     push:
     pull_request:
   ```
   
   or we can keep it as a guide for the PR reviewer but not requiring all PR to pass all the tests. It will be up to the PR reviewer to decide if the failed tests should be fixed in this PR or not. I would propose to keep it because sometimes it is better to discover the failed tests in the PR before the merge. But all the team can vote on the best options for triggering the workflow. There are many [events for workflow trigger](https://docs.github.com/en/actions/reference/events-that-trigger-workflows) and may be some of them can be enabled on some specific workflows.
   
   > Also another problem is that if team members A and B working on the same branch, their code can pass the CI test separately, but may not be compatible to each other (e.g. due to API change)
   
   If the `push:` trigger is enabled, this problem will be discovered when the second team member pushes the code and the workflow is triggered.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689958872


   I think I got the different between "push" and "pull_request" clearer now:
   
   From this webpage: https://frontside.com/blog/2020-05-26-github-actions-pull_request/
   This page says that:
   "This difference means that a pull_request workflow ref would look like refs/remotes/pull/##/merge whereas a push workflow would be refs/heads/branch_name. This explains why the SHA of a push workflow matches the commit that triggered the workflow, whereas the SHA of a pull_request workflow does not; instead **the SHA of the pull_request is the resulting commit that was created from merging the base to the head**."


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
nudles commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-690816957


   > 
   > 
   > This PR removes Travis CI since we are using Github Actions now. :octocat:
   > 
   >     * We will not run the cpp and python lint commands:
   > 
   > 
   > tool/linting/py.sh
   > tool/linting/cpp.sh
   > 
   > Instead we can just use the output of Github's lgtm. Is this fine with everyone?
   > 
   >     * We do not have a github workflow that publishes the conda packages. If this is required, we can add the [Conda Package Publish Action](https://github.com/marketplace/actions/conda-package-publish-action) at the end of the conda workflow. Assuming there is secrets.ANACONDA_PASSWORD and secrets.ANACONDA_USERNAME defined in the [github secrets](https://docs.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) of the user who runs this workflow.
   > 
   
   How can we set the secrets? There is no `setting` tab for this project..
   
   >     * Currently the github workflows use the latest Ubuntu only. If it is required to support another older versions, we can add them to the workflow. Travis CI was checking Ubuntu 14.04, 16.04 and 18.04.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-687871960


   # [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=h1) Report
   > Merging [#790](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/7586a3b14ef9a4d122435d624d8e6ae7f99c6e89?el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/790/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##              dev     #790   +/-   ##
   =======================================
     Coverage   65.08%   65.08%           
   =======================================
     Files          86       86           
     Lines        4786     4786           
   =======================================
     Hits         3115     3115           
     Misses       1671     1671           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.08% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=footer). Last update [7586a3b...ea17426](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris removed a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris removed a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689439017


   Sometime don't know why only
   `Native-Ubuntu / build-cpptest-on-cpu (pull_request)`  is here below
   But 
   `Native-Ubuntu / build-cpptest-on-cpu (push)` is not here (e.g. in this PR)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] moazreyad commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
moazreyad commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-690927600






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles merged pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
nudles merged pull request #790:
URL: https://github.com/apache/singa/pull/790


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] moazreyad commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
moazreyad commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-690927600


    > How can we set the secrets? There is no `setting` tab for this project..
   
   There are two solutions:
   
   1. The secrets can be stored in the forked repository of the project by the person who wants to publish to conda. Then the conda publishing workflow will run only from this forked repository because it is the only place where the secrets are defined. 
   
   2. The better option is to ask the Apache INFRA to add the secrets to the project.  In this case we don't store username and password, but we store the conda upload token. You may open a ticket similar to [this one](https://issues.apache.org/jira/browse/INFRA-20602) and send the token and explicit instructions as to how to create the token to root@apache.org. The same also can be done for publishing to PyPi.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-687871960


   # [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=h1) Report
   > Merging [#790](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/7586a3b14ef9a4d122435d624d8e6ae7f99c6e89?el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/790/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##              dev     #790   +/-   ##
   =======================================
     Coverage   65.08%   65.08%           
   =======================================
     Files          86       86           
     Lines        4786     4786           
   =======================================
     Hits         3115     3115           
     Misses       1671     1671           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=footer). Last update [7586a3b...ea17426](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] moazreyad commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
moazreyad commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-690927600


    > How can we set the secrets? There is no `setting` tab for this project..
   
   There are two solutions:
   
   1. The secrets can be stored in the forked repository of the project by the person who wants to publish to conda. Then the conda publishing workflow will run only from this forked repository because it is the only place where the secrets are defined. 
   
   2. The better option is to ask the Apache INFRA to add the secrets to the project.  In this case we don't store username and password, but we store the conda upload token. You may open a ticket similar to [this one](https://issues.apache.org/jira/browse/INFRA-20602) and send the token and explicit instructions as to how to create the token to root@apache.org. The same also can be done for publishing to PyPi.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689958872


   I think I got the difference between "push" and "pull_request" clearer now:
   
   From this webpage: https://frontside.com/blog/2020-05-26-github-actions-pull_request/
   This page says that:
   "This difference means that a pull_request workflow ref would look like refs/remotes/pull/##/merge whereas a push workflow would be refs/heads/branch_name. This explains why the SHA of a push workflow matches the commit that triggered the workflow, whereas the SHA of a pull_request workflow does not; instead **the SHA of the pull_request is the resulting commit that was created from merging the base to the head**."
   
   So the trigger of pull_request is very useful because it seems to use the merged code (from base to head) for test, which accounts for the compatibility to the base branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-688065275


   I have a question: the current CI use the current PR branch for CI test. 
   
   In this case, if one PR fixes a bug that cause a failed CI test, some other PR still cannot pass the test unless rebased to dev branch
   
   Would it be a better practice if we use the merged branch instead of the PR branch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-687871960


   # [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=h1) Report
   > Merging [#790](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/7586a3b14ef9a4d122435d624d8e6ae7f99c6e89?el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/790/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##              dev     #790   +/-   ##
   =======================================
     Coverage   65.08%   65.08%           
   =======================================
     Files          86       86           
     Lines        4786     4786           
   =======================================
     Hits         3115     3115           
     Misses       1671     1671           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=footer). Last update [7586a3b...426963d](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] chrishkchris commented on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
chrishkchris commented on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-689439017


   Sometime don't know why only
   `Native-Ubuntu / build-cpptest-on-cpu (pull_request)`  is here above
   But 
   `Native-Ubuntu / build-cpptest-on-cpu (push)` is not here (e.g. in this PR)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] edited a comment on pull request #790: Remove Travis CI

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #790:
URL: https://github.com/apache/singa/pull/790#issuecomment-687871960


   # [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=h1) Report
   > Merging [#790](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/7586a3b14ef9a4d122435d624d8e6ae7f99c6e89?el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/790/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev     #790      +/-   ##
   ==========================================
   + Coverage   65.08%   65.21%   +0.13%     
   ==========================================
     Files          86      104      +18     
     Lines        4786    12414    +7628     
   ==========================================
   + Hits         3115     8096    +4981     
   - Misses       1671     4318    +2647     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.08% <ø> (?)` | |
   | #singa-python | `65.29% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [proto/io\_pb2.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-cHJvdG8vaW9fcGIyLnB5) | `0.00% <0.00%> (ø)` | |
   | [utils.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | `65.78% <0.00%> (ø)` | |
   | [data.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | `0.00% <0.00%> (ø)` | |
   | [opt.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-b3B0LnB5) | `48.31% <0.00%> (ø)` | |
   | [proto/core\_pb2.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-cHJvdG8vY29yZV9wYjIucHk=) | `0.00% <0.00%> (ø)` | |
   | [model.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | `89.65% <0.00%> (ø)` | |
   | [sonnx.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-c29ubngucHk=) | `91.94% <0.00%> (ø)` | |
   | [tensor.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-dGVuc29yLnB5) | `75.19% <0.00%> (ø)` | |
   | [\_\_init\_\_.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-X19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
   | [autograd.py](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | `89.99% <0.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/singa/pull/790/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=footer). Last update [7586a3b...ea17426](https://codecov.io/gh/apache/singa/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org