[GitHub] [hadoop-ozone] cxorm removed a comment on pull request #1233: HDDS-3725. Ozone sh volume client support quota option.

[GitBox <gi...@apache.org>]

cxorm removed a comment on pull request #1233:
URL: https://github.com/apache/hadoop-ozone/pull/1233#issuecomment-662824611


   Thanks @captainzmc for the work.
   Overall the functionalily-part is good and some suggestions is added inline, test-related-part would be reviewd soon.
   
   Here I have two Questions IMHO.
   
   (1) Could we let the variable-pair be consistent ?
   I think it would better to use one of (`storagespaceQuota`/ `namespaceQuota`) and (`quotaInBytes`/ `quotaInCounts`).
   If it have other purpose to use both, please let me know.
   
   (2) Would we add limitation of creating volume and bucket in later patch ?
   I deployed this patch on my machine, and created volume without setting both of quota.
   I found that the storage of volume exceeds my local-storage.
   And I found we could create bucket even if the quota of bucket is -1.
   ![create_bucket](https://i.imgur.com/oN1Jf4X.png)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org