You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/08 18:22:48 UTC

[GitHub] [helix] rahulrane50 opened a new pull request #1972: Upgrading Zookeeper version to 3.6.13 to enanle zk client SSL/TLS

rahulrane50 opened a new pull request #1972:
URL: https://github.com/apache/helix/pull/1972


   
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #1971 by upgrading ZooKeeper version to 3.6.3
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR upgrades the Zookeeper version to 3.6.3 which allows Helix to to talk to Zookeeper to secured port.
   Zookeeper has enabled SSL/TLS version from 3.5.6+. 
   
   WIth Zookeeper 3.6.3, there are changes in signature of one of the methods of SerializeUtils class. Added a 
   fix to support that. 
   
   ### Tests
   
   - [] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   No new tests added but dependent on CI tests.
   - The following is the result of the "mvn test" command on the appropriate module:
   
   (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
   
   (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] narendly commented on pull request #1972: Upgrading Zookeeper version to 3.6.13 to enanle zk client SSL/TLS

Posted by GitBox <gi...@apache.org>.
narendly commented on pull request #1972:
URL: https://github.com/apache/helix/pull/1972#issuecomment-1062116717


   Please fix typo in the commit title


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] desaikomal commented on pull request #1972: Upgrading Zookeeper version to 3.6.13 to enanle zk client SSL/TLS

Posted by GitBox <gi...@apache.org>.
desaikomal commented on pull request #1972:
URL: https://github.com/apache/helix/pull/1972#issuecomment-1062078991


   Thanks @rahulrane50.  Change looks good to me based on version change. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] narendly merged pull request #1972: Upgrading Zookeeper version to 3.6.13 to enanle zk client SSL/TLS

Posted by GitBox <gi...@apache.org>.
narendly merged pull request #1972:
URL: https://github.com/apache/helix/pull/1972


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org