[jira] [Commented] (MESOS-3639) Implement stout/os/windows/killtree.hpp

["Joris Van Remoortere (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307067#comment-15307067 ] 

Joris Van Remoortere commented on MESOS-3639:
---------------------------------------------

{code}
commit 563c9ff5b539dc2d4ce1ba987dec925045cef5b8
Author: Daniel Pravat <dp...@outlook.com>
Date:   Mon May 30 18:02:24 2016 -0700

    Windows: Enabled `JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE` on job objects.
    
    Review: https://reviews.apache.org/r/47442/
{code}

> Implement stout/os/windows/killtree.hpp
> ---------------------------------------
>
>                 Key: MESOS-3639
>                 URL: https://issues.apache.org/jira/browse/MESOS-3639
>             Project: Mesos
>          Issue Type: Task
>          Components: stout
>            Reporter: Alex Clemmer
>            Assignee: Daniel Pravat
>              Labels: mesosphere, windows
>             Fix For: 0.29.0
>
>
> killtree() is implemented using Windows Job Objects. The processes created by the  executor are associated with a job object using `create_job'. killtree() is simply terminating the job object. 
> Helper functions:
> `create_job` function creates a job object whose name is derived from the `pid` and associates the `pid` process with the job object. Every process started by the process which is part of the job object becomes part of the job object. The job name should match the name used in `kill_job`. The jobs should be create with JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE and allow the caller to decide how to handle the returned handle. 
> `kill_job` function assumes the process identified by `pid` is associated with a job object whose name is derive from it. Every process started by the process which is part of the job object becomes part of the job object. Destroying the task will close all such processes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)