You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/11/09 09:23:09 UTC
Review Request 63693: KYLIN-3024 Limit the "Auto Merge Thresholds"
text box to be input a negative number
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63693/
-----------------------------------------------------------
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Bugs: KYLIN-3024
https://issues.apache.org/jira/browse/KYLIN-3024
Repository: kylin
Description
-------
When you create a new cube or edit a existent cube, then do as follows
1. Open the "Refresh Setting";
2. Write one value for "Auto Merge Thresholds" parameter;
Then you will find the text box can be input negative numbers, which can be summited, it should be invalid.
Diffs
-----
webapp/app/partials/cubeDesigner/refresh_settings.html 522fe50
Diff: https://reviews.apache.org/r/63693/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 63693: KYLIN-3024 Limit the "Auto Merge
Thresholds" text box to be input a negative number
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63693/
-----------------------------------------------------------
(Updated εδΈζ 17, 2017, 3:15 a.m.)
Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.
Changes
-------
Update my patch, please check it, thanks.
Bugs: KYLIN-3024
https://issues.apache.org/jira/browse/KYLIN-3024
Repository: kylin
Description
-------
When you create a new cube or edit a existent cube, then do as follows
1. Open the "Refresh Setting";
2. Write one value for "Auto Merge Thresholds" parameter;
Then you will find the text box can be input negative numbers, which can be summited, it should be invalid.
Diffs (updated)
-----
webapp/app/partials/cubeDesigner/refresh_settings.html 522fe50
Diff: https://reviews.apache.org/r/63693/diff/2/
Changes: https://reviews.apache.org/r/63693/diff/1-2/
Testing
-------
Thanks,
pengjianhua