You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by "Hermann, Eckehard" <Ec...@softwareag.com> on 2002/03/04 10:54:02 UTC

RE: cvs commit: jakarta-slide/src/share/org/apache/slide/authenti cate CredentialsToken.java

Sorry, my mistake. I added the 'c' now.

regards Eckehard

-----Original Message-----
From: Remy Maucherat [mailto:remm@apache.org]
Sent: Saturday, March 02, 2002 8:06 PM
To: Slide Developers Mailing List
Subject: Re: cvs commit:
jakarta-slide/src/share/org/apache/slide/authenticate
CredentialsToken.java


> 26.02.2002 09:49:32, juergen@apache.org wrote:
> >juergen     02/02/26 00:49:32
> >
> >  Modified:    src/share/org/apache/slide/authenticate
> >                        CredentialsToken.java
> >  Log:
> >  cache principal instance and added getPrincipal method. Because I
> >  need the principal in the stores (Eckehard)
>
> [snip]
> >  +    /**
> >  +     * Returns the current principal
> >  +     *
> >  +     * @return java.security.Principal
> >  +     */
> >  +    public Principal getPrinipal() {
> >  +         return principal;
> >  +    }
>
> Ermmm, that should be getPrincipal() instead of getPrinipal(), I'm
> sure (focus on the missing 'c').
> :o)
>
> >       /**
> >        * Returns the public creddentials.
> >  -     *
> >  -     * @return String
> >  +     *
> >  +     * @return String
> >        */
> >       public String getPublicCredentials() {
> >           return credentials;
>
> Why is it that the commits coming from you guys always report plenty
> of 'invisible' changes, like removed whitespace at end of line etc.
> It makes looking at the diffs really cumbersome. Would it be possible
> to turn that off (assuming it's being done automatically by your
> favorite editor) ?

My original sources did contain tabs. Apparently Juergen's editor converts
the tabs to spaces (hopefully, it's not the other way around ;-)), which is
good in some ways, but isn't too good an idea.

If we want to get rid of tabs, we should do it all at once, IMO. Otherwise,
it makes the diffs really annoying to deal with, as Christopher pointed out.

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>