[jira] [Commented] (HDFS-17027) RBF: Add supports for observer.auto-msync-period when using routers

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726974#comment-17726974 ] 

ASF GitHub Bot commented on HDFS-17027:
---------------------------------------

simbadzina opened a new pull request, #5693:
URL: https://github.com/apache/hadoop/pull/5693

   HDFS-17027. RBF: Adds auto-msync support for clients connecting to routers.
   
   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   Adds auto-msync support for clients connecting to routers.
   
   ### How was this patch tested?
   Modified tests in `TestObserverWithRouter` to also run with the proxyprovider configs. 
   
   ### For code changes:
   
   - [X ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   
   




> RBF: Add supports for observer.auto-msync-period when using routers
> -------------------------------------------------------------------
>
>                 Key: HDFS-17027
>                 URL: https://issues.apache.org/jira/browse/HDFS-17027
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Simbarashe Dzinamarira
>            Assignee: Simbarashe Dzinamarira
>            Priority: Major
>
> None-RBF clients that use observer reads have the option to set *dfs.client.failover.observer.auto-msync-period.<nameservice>* . This config makes the client automatically do an msync, allowing clients to use the observer reads feature without any code change.
> To use observer reads with RBF, clients set *dfs.client.rbf.observer.read.enable*. The way this flag is implemented does not allow clients to use the *auto-msync-period* config. So with RBF, clients either have to 
> # Not use observer reads
> # Use observer reads with the risk of stale reads
> # Make code changes to explicitly call msync.
> We should add support for *dfs.client.failover.observer.auto-msync-period.<nameservice>*. This can be done by adding a ProxyProvider, in a similar manner to the ObserverReadProxyProvider.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org