You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by "Tilman Hausherr (JIRA)" <ji...@apache.org> on 2015/03/13 10:56:38 UTC
[jira] [Comment Edited] (PDFBOX-2576) Improve code quality
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360043#comment-14360043 ]
Tilman Hausherr edited comment on PDFBOX-2576 at 3/13/15 9:56 AM:
------------------------------------------------------------------
I have a feeling that if I commit this patch, more of them will be coming and it will affect every method in the project, because of that "final" thing. Could you resubmit that one without "make everything final that can be final"? I'm aware that there can be a reason for this, but we can catch (future) violations in SonarQube. (Maybe I should really fix the existing violations, e.g. in the StandardSecurityHandler class). A google search for "make parameters final" shows a lot of pro and con arguments.
I really like patches that make code shorter and easier to read, not longer :-)
Additional small wish: name your patches .patch or .diff, not .txt, this makes it faster for me.
What code checking tool are you using? Or is this standard in your IDE?
was (Author: tilman):
I have a feeling that if I commit this patch, more of them will be coming and it will affect every method, because of that "final" thing. Could you resubmit that one without "make everything final that can be final"? I'm aware that there can be a reason for this, but we can catch (future) violations in SonarQube. (Maybe I should really fix the existing violations, e.g. in the encryption classes). A google search for "make parameters final" shows a lot of pro and con arguments.
I really like patches that make code shorter and easier to read, not longer :-)
Additional small wish: name your patches .patch or .diff, not .txt, this makes it faster for me.
What code checking tool are you using? Or is this standard in your IDE?
> Improve code quality
> --------------------
>
> Key: PDFBOX-2576
> URL: https://issues.apache.org/jira/browse/PDFBOX-2576
> Project: PDFBox
> Issue Type: Task
> Affects Versions: 2.0.0
> Reporter: Tilman Hausherr
> Attachments: pdfbox-override-patch.txt, pdfbox-raw-type-patch.txt, pdfcloneutility-patch.txt, pdftextstripperbyarea-patch.txt, ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the [SonarQube report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor], hints in different IDEs, the FindBugs tool and other code quality tools.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org