You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/01/27 22:19:29 UTC
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15110
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Modifies the ClusterMembershipMgr so that it prints a log statement
everytime a node is removed from the blacklist. The log statement
includes the reason the node was removed from the blacklist as well.
Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
---
M be/src/scheduling/cluster-membership-mgr.cc
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/15110/1
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15110 )
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Modifies the ClusterMembershipMgr so that it prints a log statement
everytime a node is removed from the blacklist. The log statement
includes the reason the node was removed from the blacklist as well.
Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Reviewed-on: http://gerrit.cloudera.org:8080/15110
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/cluster-membership-mgr.cc
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15110 )
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15110/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/15110/1/be/src/scheduling/cluster-membership-mgr.cc@254
PS1, Line 254: // Update
Sorta outside the scope of this patch, but it might be nice to add some comments/dchecks here reflecting what we were talking about earlier, eg. that it shouldn't be the case that this flips a BE from quiescing to non-quiescing
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2020 22:38:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15110 )
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5473/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 01:55:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15110 )
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5533/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2020 23:04:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15110 )
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15110/1/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:
http://gerrit.cloudera.org:8080/#/c/15110/1/be/src/scheduling/cluster-membership-mgr.cc@254
PS1, Line 254: // Update
> Sorta outside the scope of this patch, but it might be nice to add some com
Will do in a follow up patch, want to get this merged to help debug IMPALA-9262
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 01:54:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15110 )
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 06:42:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15110 )
Change subject: IMPALA-9334: Log node blacklisting removals in ClusterMembershipMgr
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id09217803ab2996d78113c4e208da156dda1dbbf
Gerrit-Change-Number: 15110
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 01:55:21 +0000
Gerrit-HasComments: No