You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/15 17:34:10 UTC
[GitHub] [spark] ChuliangXiao opened a new pull request #30060: Fix the typo in the docstring of method agg()
ChuliangXiao opened a new pull request #30060:
URL: https://github.com/apache/spark/pull/30060
Change `df.groupBy.agg()` to `df.groupBy().agg()` in the docstring of `agg()`
### What changes were proposed in this pull request?
Fix typo in a docstring
### Why are the changes needed?
Fix typo in a docstring
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30060: Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30060:
URL: https://github.com/apache/spark/pull/30060#discussion_r505799506
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -1514,7 +1514,7 @@ def cube(self, *cols):
@since(1.3)
def agg(self, *exprs):
""" Aggregate on the entire :class:`DataFrame` without groups
- (shorthand for ``df.groupBy.agg()``).
+ (shorthand for ``df.groupBy().agg()``).
Review comment:
cc @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30060: Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30060:
URL: https://github.com/apache/spark/pull/30060#issuecomment-709482554
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30060: Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30060:
URL: https://github.com/apache/spark/pull/30060#discussion_r505935282
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -1514,7 +1514,7 @@ def cube(self, *cols):
@since(1.3)
def agg(self, *exprs):
""" Aggregate on the entire :class:`DataFrame` without groups
- (shorthand for ``df.groupBy.agg()``).
+ (shorthand for ``df.groupBy().agg()``).
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ChuliangXiao commented on a change in pull request #30060: Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
ChuliangXiao commented on a change in pull request #30060:
URL: https://github.com/apache/spark/pull/30060#discussion_r505804712
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -1514,7 +1514,7 @@ def cube(self, *cols):
@since(1.3)
def agg(self, *exprs):
""" Aggregate on the entire :class:`DataFrame` without groups
- (shorthand for ``df.groupBy.agg()``).
+ (shorthand for ``df.groupBy().agg()``).
Review comment:
> Thank you for your contribution. Is this the last one? Could you check the other examples in this file, please?
My pleasure. This is the only instance in the current version branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30060: Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30060:
URL: https://github.com/apache/spark/pull/30060#issuecomment-709481609
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30060: Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30060:
URL: https://github.com/apache/spark/pull/30060#issuecomment-709481609
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30060: [MINOR][PYTHON] Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30060:
URL: https://github.com/apache/spark/pull/30060
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30060: Fix the typo in the docstring of method agg()
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30060:
URL: https://github.com/apache/spark/pull/30060#discussion_r505799278
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -1514,7 +1514,7 @@ def cube(self, *cols):
@since(1.3)
def agg(self, *exprs):
""" Aggregate on the entire :class:`DataFrame` without groups
- (shorthand for ``df.groupBy.agg()``).
+ (shorthand for ``df.groupBy().agg()``).
Review comment:
Thank you for your contribution. Is this the last one? Could you check the other examples in this file, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org