You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/04/24 09:10:47 UTC
[Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
#40: Merge existing plugins into a single Bloodhound UI plugin
-----------------------------------+--------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Keywords: dashboard theme merge |
-----------------------------------+--------------------
IMO Bloodhound Theme and Dashboard plugins have a lot in common, might
share some artifacts and they both are about user interfaces . I suggest
to merge them into a single plugin.
I look forward to your comments.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by gjm):
We shouldn't be repeating code. It would be nice to separate out theme and
UI but if it is turning out that these are the same thing, we can combine
these. The alternative would be to separate out the common parts and
either put them into the trac core code or a component that both theme and
dashboard rely on.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by gjm):
r1338765 removes the directories that should have been removed in r1336709
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by gjm):
r1336588 adds the glyphicons to dashboard
r1336707 makes the theme dependent on dashboard being available and adds
the milestone view to the theme plugin
r1336709 removes the milestone view from the dashboard
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by olemis):
Related to #50
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by gjm):
I can see what you mean but I think we may need some time to investigate
whether there is a way for us to decouple the plugins enough to resolve
this problem.
In the short term, the quickest solution (of sorts) would be to make one
or the other plugin a dependency so that there is some guarantee of code,
templates and resources being available.
If such a package dependency is created, we should leave this ticket open
to drive the discussion of a more permanent solution.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by gjm):
I don't understand why #51 and #54 are dependent on a decision on this
ticket.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by olemis):
Let me explain myself better , and maybe it will be more clear why I'm
requesting to merge them into a single package (e.g. '''.egg''' file)
rather than e.g. splitting them into three .
It is a fact that there are some ''Genshi'' templates common to both
dashboard and theme . Nonetheless any one of them should not be a
requirement to use the other as they may be (enabled | disabled)
independently . Hence the idea is :
1. to distribute them in a single package
(which also means that common templates are at a
single location within distribution ''';)'''
2. make both , theme and dashboard check whether
the other is enabled or not so as to ensure
common templates location will always be available
3. ... and '''(2)''' can happen with eyes closed
(i.e. no further checking ... ) due to the fact that
those files will always be there because a package
is distributed as a whole ; hence all parts of it
are deployed together everywhere .
... otherwise afaics there are two scenarios :
1. copies of common templates are distributed in each package
( i.e. duplicated source code ... something I do not like )
2. both , dashboard and theme depend upon a third component
in a separate package that should be
(installed | enabled | ...) but maybe not . Therefore
additional checks will be needed with extra complexity involved.
Finally both #51 and #54 are dependent on this because the template(s)
needed to render the results of executing custom queries and reports is
already implemented in dashboard plugin . They are used by respective
widgets which were needed before to implement previous designs . These
templates now need to be available so that theme code will be able to
reuse them when rendering web UI . That's another reason to merge both
plugins .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by olemis):
Attached patches illustrate how to introduce the dependency between theme
plugin and dashboard and migrate previous implementation of
[https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
templates/milestone.html milestone web UI design] so as to distribute it
as part of theme plugin.
==== Changes in dashboard plugin ====
{{{
#!sh
$ hg qapplied
t40/t40_r1328362_duplicate_webui.diff
t40/t40_r1328362_glyphicons_dashboard.diff
t40/t40_r1328362_remove_milestone_view.diff
}}}
==== Changes in theme plugin ====
{{{
#!sh
$ hg qapplied
t40/t40_r1335525_theme_requires_dashboard.diff
t40/t40_r1335525_move_milestone_view_theme.diff
}}}
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by olemis):
Initially I considered they were different enough so as to deserve to be
distributed as different packages . Nonetheless , in practice it's a fact
that they both are tightly coupled . This happens mainly
1. as a consequence of the characteristics of the designs ,
which incorporate inside the theme features implemented in dashboard
.
2. due to the fact that there's a lot of reuse between widgets
(implemented in dashboard) and ''Genshi'' templates overriding
default
look and feel so as to update to bootstrap particular parts of the UI
(e.g. search , reports, queries , ...)
In order to avoid packaging overhead I'd suggest to merge them all in a
single package . IMO it's more simple that way .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #40: Merge existing plugins into a single
Bloodhound UI plugin
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#40: Merge existing plugins into a single Bloodhound UI plugin
--------------------------+-----------------------------------
Reporter: olemis | Owner: nobody
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: dashboard | Version:
Resolution: | Keywords: dashboard theme merge
--------------------------+-----------------------------------
Comment (by olemis):
Related to #51 #54
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/40#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker