[GitHub] [incubator-superset] villebro commented on a change in pull request #9652: fix: adhoc filter 'equals' doesn't let you save

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9652:
URL: https://github.com/apache/incubator-superset/pull/9652#discussion_r420006759



##########
File path: superset-frontend/spec/javascripts/explore/AdhocFilter_spec.js
##########
@@ -153,6 +153,27 @@ describe('AdhocFilter', () => {
     });
     // eslint-disable-next-line no-unused-expressions
     expect(adhocFilter5.isValid()).toBe(true);
+
+    const adhocFilter6 = new AdhocFilter({
+      expressionType: EXPRESSION_TYPES.SIMPLE,
+      subject: 'value',
+      operator: '==',
+      comparator: 1,
+      clause: CLAUSES.WHERE,
+    });
+    // eslint-disable-next-line no-unused-expressions
+    expect(adhocFilter6.isValid()).toBe(true);

Review comment:
       Should this be `comparator: 0`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org