[jira] [Commented] (HBASE-11599) BloomFilterFactory.IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED is never used

["Apekshit Sharma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380841#comment-14380841 ] 

Apekshit Sharma commented on HBASE-11599:
-----------------------------------------

Hi Ranjana

I believe IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED simply stores the name of a configuration setting which can be set to true or false in some config file. So users can have following in their config,
io.storefile.delete.family.bloom.enabled = true/false

You're right that it's only used in one place, in function isDeleteFamilyBloomEnabled(Configuration conf)

{code}
public static boolean isDeleteFamilyBloomEnabled(Configuration conf) {
  return conf.getBoolean(IO_STOREFILE_DELETE_FAMILY_BLOOM_ENABLED, true);
}
{code}

However, it's not trying to check value of the variable to be true, instead, getBoolean(String name, boolean defaultValue) tries to get the value of 'name' setting from the configuration 'conf' and returns it. If the setting is not found or is mis-configured (a value other that true or false - case insensitive), it returns defaultValue.

Since users may be using it, I think we shouldn't clean it.

> BloomFilterFactory.IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED is never used
> ------------------------------------------------------------------------
>
>                 Key: HBASE-11599
>                 URL: https://issues.apache.org/jira/browse/HBASE-11599
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 0.94.21, 0.98.4, 2.0.0
>            Reporter: Jean-Marc Spaggiari
>            Priority: Minor
>              Labels: beginner
>
> BloomFilterFactory.IO_STOREFILE_DELETEFAMILY_BLOOM_ENABLED is not used anywhere. I think we should clean it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)