[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #868: HUDI-180 : Adding support for hive registration using metastore along with JDBC

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #868: HUDI-180 : Adding support for hive registration using metastore along with JDBC
URL: https://github.com/apache/incubator-hudi/pull/868#discussion_r320030393
 
 

 ##########
 File path: hudi-hive/src/test/java/org/apache/hudi/hive/HiveSyncToolTest.java
 ##########
 @@ -39,10 +41,25 @@
 import org.joda.time.DateTime;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
 
 @SuppressWarnings("ConstantConditions")
+@RunWith(Parameterized.class)
 public class HiveSyncToolTest {
 
+  // Test sync tool using both jdbc and metastore client
+  private boolean useJdbc;
+
+  public HiveSyncToolTest(Boolean useJdbc) {
 
 Review comment:
   Looks clean !!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services