[GitHub] [hive] kishendas commented on a change in pull request #1956: HIVE-24743: Send tableId in get_partitions_by_names HMS API

[GitBox <gi...@apache.org>]

kishendas commented on a change in pull request #1956:
URL: https://github.com/apache/hive/pull/1956#discussion_r573970499



##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -2223,6 +2224,29 @@ public PartitionsResponse getPartitionsRequest(PartitionsRequest req)
     return deepCopyPartitions(FilterUtils.filterPartitionsIfEnabled(isClientFilterEnabled, filterHook, parts));
   }
 
+  @Override
+  public GetPartitionsByNamesResult getPartitionsByNames(GetPartitionsByNamesRequest req)
+          throws NoSuchObjectException, MetaException, TException {
+    checkDbAndTableFilters(req.getCatName(), req.getDb_name(), req.getTbl_name());
+    req.setDb_name(prependCatalogToDbName(req.getCatName(), req.getDb_name(), conf));
+    if (req.getValidWriteIdList() == null) {
+      req.setValidWriteIdList(getValidWriteIdList(prependCatalogToDbName(req.getCatName(), req.getDb_name(),
+              conf), req.getTbl_name()));
+    }
+    if (req.getId() <= 0) {
+      req.setId(getTable(prependCatalogToDbName(req.getCatName(), req.getDb_name(), conf), req.getTbl_name()).getId());

Review comment:
       That's right. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org