You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/14 13:59:36 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
rkhachatryan opened a new pull request #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097
## What is the purpose of the change
*Use ChainingStrategy ALWAYS in ContinuousFileReaderOperatorFactory*
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #11097: [FLINK-16057][runtime]
chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-587343883
Thanks for the explanation and the fix. Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #11097: [FLINK-16057][runtime]
chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586910454
Yes,
1. for one thing operators that do use `mailbox.yield()`, can not be chained with the legacy sources.
2. CFRO is always 2nd operator in the job graph, just after the legacy `SourceFunction`, so effectively it has to be always a head of the chain plus I think `SourceFunction` for `CFRO` has always parallelism 1, so all in all enabling chaining in benchmarks is a bit unrealistic setup.
3. As far as I can see, before your changes @rkhachatryan, the CFRO was not chained in the benchmarks. So this change is not fixing the performance regression, but only hiding it behind some other unrelated improvement, or am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11097: [FLINK-16057][runtime]
chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski commented on issue #11097: [FLINK-16057][runtime]
chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-587336578
> Previously, CFRO was chained using HEAD strategy
Yes, this is what I meant. Ok, so currently on master, CFRO is not chained at all? Indeed that should be changed to `HEAD`. @rkhachatryan does this improve some benchmark results?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148989001 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148989001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148989001 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148989001) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] aljoscha commented on issue #11097: [FLINK-16057][runtime]
chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
aljoscha commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586343357
@pnowojski Wasn't there an issue that the Async I/O operator and continuous file reader should never be chained because of some weird interaction in the threading/processing time timers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148989001 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:a6ff92a77069e335dae59410456b1e15b5928e91 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a6ff92a77069e335dae59410456b1e15b5928e91
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148989001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186)
* a6ff92a77069e335dae59410456b1e15b5928e91 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] pnowojski merged pull request #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148989001 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:a6ff92a77069e335dae59410456b1e15b5928e91 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149304115 TriggerType:PUSH TriggerID:a6ff92a77069e335dae59410456b1e15b5928e91
Hash:a6ff92a77069e335dae59410456b1e15b5928e91 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5256 TriggerType:PUSH TriggerID:a6ff92a77069e335dae59410456b1e15b5928e91
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148989001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186)
* a6ff92a77069e335dae59410456b1e15b5928e91 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149304115) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5256)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148989001 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:a6ff92a77069e335dae59410456b1e15b5928e91 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149304115 TriggerType:PUSH TriggerID:a6ff92a77069e335dae59410456b1e15b5928e91
Hash:a6ff92a77069e335dae59410456b1e15b5928e91 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5256 TriggerType:PUSH TriggerID:a6ff92a77069e335dae59410456b1e15b5928e91
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148989001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186)
* a6ff92a77069e335dae59410456b1e15b5928e91 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149304115) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5256)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148989001 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:a6ff92a77069e335dae59410456b1e15b5928e91 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149304115 TriggerType:PUSH TriggerID:a6ff92a77069e335dae59410456b1e15b5928e91
Hash:a6ff92a77069e335dae59410456b1e15b5928e91 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5256 TriggerType:PUSH TriggerID:a6ff92a77069e335dae59410456b1e15b5928e91
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148989001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186)
* a6ff92a77069e335dae59410456b1e15b5928e91 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149304115) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5256)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586314064
<!--
Meta data
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148989001 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
Hash:696fdaf53d04470d7e2917a3d88b3738408eb849 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186 TriggerType:PUSH TriggerID:696fdaf53d04470d7e2917a3d88b3738408eb849
-->
## CI report:
* 696fdaf53d04470d7e2917a3d88b3738408eb849 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148989001) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5186)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11097: [FLINK-16057][runtime]
chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-586301026
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 696fdaf53d04470d7e2917a3d88b3738408eb849 (Fri Feb 14 14:02:39 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-587341457
Yes, @pnowojski, by about 50% compared to the current `master` (still 25% slower than multi-threaded version).
Please see build 146 of `flink-benchmark-request`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-587133618
CI failure on travis was caused by https://issues.apache.org/jira/browse/FLINK-16118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on issue #11097:
[FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on issue #11097: [FLINK-16057][runtime] chain ContinuousFileReaderOperator by default
URL: https://github.com/apache/flink/pull/11097#issuecomment-587055715
Thanks for pointing it out.
Previously, `CFRO` **was** chained using `HEAD` strategy (see `AbstractStreamOperator#chainingStrategy`).
I've updated the PR to use this strategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services